Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=801059 --- Comment #2 from Liang Suilong <liangsuilong@xxxxxxxxx> 2012-05-12 14:03:50 EDT --- SRPM: http://liangsuilong.fedorapeople.org/fcitx/fcitx-fbterm-0.1.4-1.fc16.src.rpm SPEC: http://liangsuilong.fedorapeople.org/fcitx/fcitx-fbterm.spec Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4072731 (In reply to comment #1) > Review:- > + koji scratch build for f17 > ->http://koji.fedoraproject.org/koji/taskinfo?taskID=4023815 > > + rpmlint on rpms gave > fcitx-fbterm.src: E: description-line-too-long C Fcitx-fbterm is a Wrapper for > Fcitx in fbterm, a fast Framebuffer based terminal emulator. > fcitx-fbterm.src:5: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line > 5) > fcitx-fbterm.src: W: invalid-url Source0: > http://fcitx.googlecode.com/files/fcitx-fbterm-0.1.2.tar.bz2 HTTP Error 404: > Not Found > fcitx-fbterm.x86_64: E: description-line-too-long C Fcitx-fbterm is a Wrapper > for Fcitx in fbterm, a fast Framebuffer based terminal emulator. > fcitx-fbterm.x86_64: W: no-documentation > fcitx-fbterm.x86_64: W: no-manual-page-for-binary fcitx-fbterm-helper > fcitx-fbterm.x86_64: W: no-manual-page-for-binary fcitx-fbterm > 2 packages and 0 specfiles checked; 2 errors, 5 warnings. > > + Source verified with upstream as (sha1sum) > cbe29bde674b90af99da5e65a2d4bb9d34f86f36 fcitx-fbterm-0.1.2.tar.bz2 > cbe29bde674b90af99da5e65a2d4bb9d34f86f36 ../SOURCES/fcitx-fbterm-0.1.2.tar.bz2 > > > Suggestions:- > 1) Fix the rpmlint messages. > a) mixed-use-of-spaces-and-tabs message can be fixed using command > sed -i 's|\t| |g' fcitx-fbterm.spec > b) description lines should be of 80 characters. Done > > 2) If package is only for Fedora then no need to add > a) %clean section (see > http://fedoraproject.org/wiki/Packaging:Guidelines#.25clean) > b) removal of buildroot in %install (remove line rm -rf $RPM_BUILD_ROOT) > c) remove line %defattr(-,root,root,-) > The package will be support el6. > 3) please don't use commands in macro that is change %{__mkdir} to "mkdir" > Done > 4) package should add Requires: fcitx, fcitx-data > Done > 5) Use following commands in %build > %cmake .. > make VERBOSE=1 %{?_smp_mflags} > Done > 6) %install should preserve timestamp using > make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" Done -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review