Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=820542 --- Comment #7 from Jerry James <loganjerry@xxxxxxxxx> 2012-05-11 12:16:40 EDT --- A few pre-review remarks: * The first line in %build, "export CFLAGS="$RPM_OPT_FLAGS", is unnecessary. The %configure macro does the same thing. See the expansion of that macro in /usr/lib/rpm/macros. * I question the usefulness of including the latex directory in %doc for the -devel subpackage. The LaTeX files are source files for the documentation. They aren't really readable by a developer wanting to use this library. For that, you want to convert them into some format targeted at a human, such as PDF or HTML. Since you're already building and packaging the HTML documentation, I see no utility in including the LaTeX sources, too. * The configure run includes this line: checking for clock_gettime... no which is wrong, because Linux does have clock_gettime(), but you have to link with -lrt. If upstream will add AC_CHECK_LIB([rt], [clock_gettime]) to configure.in, this will take care of itself. In the meantime, adding this to %prep does the trick: sed -i '/clock_gettime/iLIBS+=" -lrt"' configure * Running rpmlint on the install libguac-devel package (not the rpm) says: libguac-devel.x86_64: W: doc-file-dependency /usr/share/doc/libguac-devel-0.6.0/html/installdox /usr/bin/perl You probably don't want to install the installdox script. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review