[Bug 820642] Review Request: figlet - A program for making large letters out of ordinary text

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=820642

pcpa <paulo.cesar.pereira.de.andrade@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |paulo.cesar.pereira.de.andr
                   |                            |ade@xxxxxxxxx

--- Comment #9 from pcpa <paulo.cesar.pereira.de.andrade@xxxxxxxxx> 2012-05-11 11:14:05 EDT ---
I did talk a bit with Claudio Matsuoka about this package, and the work he
did to contact upstream to get several files relicensed under MIT/BSD like
licenses.

Claudio has a git repository at https://github.com/cmatsuoka/figlet

I did a quick review on fonts headers, and Claudio will add the LEGAL
NOTICE file commented in fonts derived from Bigelow & Holmes ones. But
I am unsure about this in the file being added:

        A royalty-free, nonexclusive trademark
 license to refer to the code and output as "OPEN LOOK" compatible 
 is available from AT&T if, and only if, the appearance of the 
 icons or glyphs is not changed in any manner except as absolutely
 necessary to accommodate the standard resolution of the screen or
 other output device, the code and output is not changed except as 
 authorized herein, and the code and output is validated by AT&T. 
 Bigelow & Holmes is the owner of the Lucida (R) trademark for the
 fonts and bit-mapped images associated with the materials on this 
 tape. Users are granted a royalty-free, nonexclusive license to use
 the trademark only to identify the fonts and bit-mapped images if, 
 and only if, the fonts and bit-mapped images are not modified in any
 way by the user.

The large C64-fonts subdirectory of the contrib fonts may have issues,
as all it says is:

NOTE: I got the font from a Commodore 64 charactor set file. (Wrote a little
program to convert them to Figlet). And since some charactors are different in
PETSCII then in ASCII, certain charactors will be different or even
non-existant. Such as `~{}\| _^

Most other "artistic" fonts come from usenet posts with the font
contents, with some interesting ones, like:

3x5 font by Richard Kirk (rak@xxxxxxxxxxxxxxx).
Ported to figlet, and slightly changed (without permission :-})
by Daniel Cabeza Gras (bardo@xxxxxxxxxxxxx)


Otherwise, most if not all have an explicit clause of free to modify,
relicense, resell. Others are explicitly public domain, or have only
author name.

I suggest not adding the contributed fonts to the main package and having
a plain figlet with only the upstream fonts, and at your interest, making
yet another figlet-fonts package and getting legal review of it.

About figlet.spec I think you should remove the shell script commented
and the %defattr commented. Not agains't comments, but comments should
be for some explanation about the reason of next code, information about
generated files, etc.

As commented previously, you could change:

%dir %{_datadir}/%{name}
%{_bindir}/*
%{_datadir}/%{name}/*

to

%{_datadir}/%{name}
%{_bindir}/*

but either way works; some like to add a slash to the end to make it
easier to notice it is a directory listing.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]