Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=820542 Ralf Corsepius <rc040203@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rc040203@xxxxxxxxxx --- Comment #5 from Ralf Corsepius <rc040203@xxxxxxxxxx> 2012-05-11 10:28:09 EDT --- Some remarks: * Please increment the Release-tag each time you modify the submission. This helps reviewers to track changes during a package's review. * (BLOCKER) The Source0-URL doesn't work. http://downloads.sourceforge.net/guacamole/libguac-0.6.0.tar.gz seems to work. * (REMARK) The package seems is passing -Werror -pedantic in its CFLAGS. This will render maintaining this package as part of a distribution hard. (-Werror causes GCC to raises warnings to errors and -pedantic raises warnings on "bizarre cases". Both together will cause architecture and gcc-version dependent build-breakdowns.) * (REMARK) In %install, rm -rf $RPM_BUILD_ROOT is not required anymore on RHEL6 or current Fedoras. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review