[Bug 820841] Review Request: python-django-dajaxice - Django AJAX library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=820841

--- Comment #7 from Matthias Runge <mrunge@xxxxxxxxxxxxxxxxx> 2012-05-11 08:01:26 EDT ---
some more comments to clean, before I'll start the review.

[!]: SHOULD Spec use %global instead of %define.
     Note: %define lang_name python %define lib_prefix django %define lib_name
     dajaxice %define lib_datadir %{_datadir}/%{name}

Issues:
[!]: MUST Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
     Note: Clean is needed only if supporting EPEL
See: http://fedoraproject.org/wiki/Packaging/Guidelines#.25clean
[!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
     Note: rm -rf is only needed if supporting EPEL5


You should increase the release number every time when you update your package.
If you post diffs, it makes it also easier for me to track the changes.

(I guess, those remarks from above also apply to your other package in review).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]