Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=812583 --- Comment #8 from Petr Pisar <ppisar@xxxxxxxxxx> 2012-05-11 05:23:19 EDT --- Great. Now I can build the package. All tests pass. Ok. $ rpmlint perl-FusionInventory-Agent-Task-NetInventory.spec ../SRPMS/perl-FusionInventory-Agent-Task-NetInventory-2.1-2.fc18.src.rpm ../RPMS/noarch/perl-FusionInventory-Agent-Task-NetInventory-2.1-2.fc18.noarch.rpm perl-FusionInventory-Agent-Task-NetInventory.src: W: spelling-error %description -l en_US informations -> information, information's, in formations perl-FusionInventory-Agent-Task-NetInventory.noarch: W: spelling-error %description -l en_US informations -> information, information's, in formations 2 packages and 1 specfiles checked; 0 errors, 2 warnings. TODO: Correct invalid word `informations' in the description. English has `information' always in singular. Plural is `data'. So I think grammatically correct sentence is `... to extracts various data...'. $ rpm -q -lv -p ../RPMS/noarch/perl-FusionInventory-Agent-Task-NetInventory-2.1-2.fc18.noarch.rpm drwxr-xr-x 2 root root 0 May 11 10:35 /usr/share/doc/perl-FusionInventory-Agent-Task-NetInventory-2.1 -rw-r--r-- 1 root root 1268 Apr 12 21:02 /usr/share/doc/perl-FusionInventory-Agent-Task-NetInventory-2.1/Changes -rw-r--r-- 1 root root 17987 Apr 13 2010 /usr/share/doc/perl-FusionInventory-Agent-Task-NetInventory-2.1/LICENSE -rw-r--r-- 1 root root 1418 Apr 10 17:38 /usr/share/doc/perl-FusionInventory-Agent-Task-NetInventory-2.1/README -rw-r--r-- 1 root root 99 Apr 10 17:38 /usr/share/doc/perl-FusionInventory-Agent-Task-NetInventory-2.1/THANKS drwxr-xr-x 2 root root 0 May 11 10:35 /usr/share/fusioninventory/lib/FusionInventory/Agent/Task/NetInventory -rw-r--r-- 1 root root 24516 Apr 12 21:04 /usr/share/fusioninventory/lib/FusionInventory/Agent/Task/NetInventory.pm drwxr-xr-x 2 root root 0 May 11 10:35 /usr/share/fusioninventory/lib/FusionInventory/Agent/Task/NetInventory/Manufacturer -rw-r--r-- 1 root root 614 Apr 10 17:38 /usr/share/fusioninventory/lib/FusionInventory/Agent/Task/NetInventory/Manufacturer.pm -rw-r--r-- 1 root root 1756 Apr 10 17:38 /usr/share/fusioninventory/lib/FusionInventory/Agent/Task/NetInventory/Manufacturer/3Com.pm -rw-r--r-- 1 root root 1753 Apr 10 17:38 /usr/share/fusioninventory/lib/FusionInventory/Agent/Task/NetInventory/Manufacturer/AlliedTelesis.pm -rw-r--r-- 1 root root 3926 Apr 10 17:38 /usr/share/fusioninventory/lib/FusionInventory/Agent/Task/NetInventory/Manufacturer/Cisco.pm -rw-r--r-- 1 root root 3600 Apr 10 17:38 /usr/share/fusioninventory/lib/FusionInventory/Agent/Task/NetInventory/Manufacturer/Nortel.pm -rw-r--r-- 1 root root 3578 Apr 10 17:38 /usr/share/fusioninventory/lib/FusionInventory/Agent/Task/NetInventory/Manufacturer/Procurve.pm -rw-r--r-- 1 root root 1969 May 11 10:35 /usr/share/man/man3/FusionInventory::Agent::Task::NetInventory.3pm.gz -rw-r--r-- 1 root root 2004 May 11 10:35 /usr/share/man/man3/FusionInventory::Agent::Task::NetInventory::Manufacturer.3pm.gz -rw-r--r-- 1 root root 1992 May 11 10:35 /usr/share/man/man3/FusionInventory::Agent::Task::NetInventory::Manufacturer::3Com.3pm.gz -rw-r--r-- 1 root root 1999 May 11 10:35 /usr/share/man/man3/FusionInventory::Agent::Task::NetInventory::Manufacturer::AlliedTelesis.3pm.gz -rw-r--r-- 1 root root 2065 May 11 10:35 /usr/share/man/man3/FusionInventory::Agent::Task::NetInventory::Manufacturer::Cisco.3pm.gz -rw-r--r-- 1 root root 2036 May 11 10:35 /usr/share/man/man3/FusionInventory::Agent::Task::NetInventory::Manufacturer::Nortel.3pm.gz -rw-r--r-- 1 root root 2000 May 11 10:35 /usr/share/man/man3/FusionInventory::Agent::Task::NetInventory::Manufacturer::Procurve.3pm.gz FIX: Why the Perl code is not installed into standard paths? I see it's because Makefile.PL adjusts it to setting of fusioninventory-agent. Modules installed into non-standard paths are not available for other Perl code and thus must not be exported as `perl()' RPM symbols. You should fix all fusioninventory-agent RPM packages. So either you need to move the modules into standard path and keep the RPM Provides, or you can keep the modules in private location but you need to remove the RPM provides (there are __provides_exclude_from and similar macros for that <http://fedoraproject.org/wiki/User:Tibbs/AutoProvidesAndRequiresFiltering>). $ rpm -q --requires -p ../RPMS/noarch/perl-FusionInventory-Agent-Task-NetInventory-2.1-2.fc18.noarch.rpm |sort |uniq -c 1 perl(base) 1 perl(constant) 1 perl(Encode) 1 perl(English) 1 perl(FusionInventory::Agent::SNMP) 1 perl(FusionInventory::Agent::Task) 1 perl(FusionInventory::Agent::Task::NetDiscovery) >= 2.1 1 perl(FusionInventory::Agent::Tools) 1 perl(FusionInventory::Agent::Tools::Network) 1 perl(FusionInventory::Agent::XML::Query) 1 perl(:MODULE_COMPAT_5.14.2) 1 perl(strict) 1 perl(threads) 1 perl(threads::shared) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 FIX: If you do not relocate the fusioninventory-agent Perl modules to standard path, remove the `perl(FusionInventory::Agent::*' dependencies because they are private. Then you will need to depend on fusioninventory-agent symbol. FIX: The same applies to BuildRequires. $ rpm -q --provides -p ../RPMS/noarch/perl-FusionInventory-Agent-Task-NetInventory-2.1-2.fc18.noarch.rpm |sort |uniq -c 1 perl(FusionInventory::Agent::Task::NetInventory) = 2.1 1 perl-FusionInventory-Agent-Task-NetInventory = 2.1-2.fc18 1 perl(FusionInventory::Agent::Task::NetInventory::Manufacturer) 1 perl(FusionInventory::Agent::Task::NetInventory::Manufacturer::3Com) 1 perl(FusionInventory::Agent::Task::NetInventory::Manufacturer::AlliedTelesis) 1 perl(FusionInventory::Agent::Task::NetInventory::Manufacturer::Cisco) 1 perl(FusionInventory::Agent::Task::NetInventory::Manufacturer::Nortel) 1 perl(FusionInventory::Agent::Task::NetInventory::Manufacturer::Procurve) 1 perl-FusionInventory-Agent-Task-SNMPQuery = 2.1-2.fc18 FIX: Remove these private `perl(FusionInventory::Agent::Task::NetInventory' Provides, if you do not relocate the files into standard path. Package builds in F18 (http://koji.fedoraproject.org/koji/taskinfo?taskID=4069923). Ok. Please provide updated spec file. Resolution: Package NOT approved. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review