Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=812575 Hans de Goede <hdegoede@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #10 from Hans de Goede <hdegoede@xxxxxxxxxx> 2012-05-11 05:06:50 EDT --- Full review done: Good: -------- - rpmlint checks return: mingw32-gstreamer-plugins-bad-free-debuginfo.noarch: E: debuginfo-without-sources mingw64-gstreamer-plugins-bad-free-debuginfo.noarch: E: debuginfo-without-sources ^^These are all expected for mingw packages, so no problem here ^^ mingw32-gstreamer-plugins-bad-free.noarch: E: incorrect-fsf-address /usr/share/doc/mingw32-gstreamer-plugins-bad-free-0.10.23/COPYING mingw64-gstreamer-plugins-bad-free.noarch: E: incorrect-fsf-address /usr/share/doc/mingw64-gstreamer-plugins-bad-free-0.10.23/COPYING mingw32-gstreamer-plugins-bad-free-debuginfo.noarch: E: description-line-too-long C This package provides debug information for package mingw32-gstreamer-plugins-bad-free. mingw64-gstreamer-plugins-bad-free-debuginfo.noarch: E: description-line-too-long C This package provides debug information for package mingw64-gstreamer-plugins-bad-free. ^^ and these can be safely ignored too ^^ - package meets naming guidelines - package meets packaging guidelines - license (LGPLv2+ and LGPLv2) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86) - no missing BR - no unnecessary BR - locales properly handled - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file Remarks: ------------- - rpmlint checks return: mingw32-gstreamer-plugins-bad-free.noarch: W: obsolete-not-provided mingw32-gstreamer-plugins-bad-free-static mingw64-gstreamer-plugins-bad-free.noarch: W: obsolete-not-provided mingw64-gstreamer-plugins-bad-free-static Were there ever mingw*-gstreamer-plugins-bad-free-static packages in Fedora? If not I suggest removing the 2 Obsoletes. No blockers: APPROVED! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review