Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=820452 Kevin Fenzi <kevin@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |182235(FE-Legal) --- Comment #2 from Kevin Fenzi <kevin@xxxxxxxxx> 2012-05-10 17:17:51 EDT --- OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. See below - License See below - License field in spec matches See below - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: f33dd8be095d6ed3f33b2e422d7b61b6 mediawiki-1.19.0.tar.gz f33dd8be095d6ed3f33b2e422d7b61b6 mediawiki-1.19.0.tar.gz.orig OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - Package obey's FHS standard (except for 2 exceptions) See below - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have sane scriptlets. OK - Should have dist tag OK - Should package latest version OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin Issues: 1. From the README, it looks like the License here should be: GPLv2+ and public domain and CC-BY-SA and looking at: "MediaWiki use Creative Commons license marks to points to their online licenses. This content is trademarked and used under a specific license available at http://creativecommons.org/policies#trademark The restricted content is: * skins/common/images/cc-by-nc-sa.png * skins/common/images/cc-by-sa.png " I think we need to remove those two files since the link says: "You are authorized to use our trademarks on the terms and conditions below, and only on the further condition that you download the trademarks directly from our website." Looking at the actual files, I see: maintenance/cssjanus/ => ASL 2.0 resources/jquery.effects/ => MIT or GPLv2+ resources/jquery/jquery.appear.js => MIT resources/jquery.ui/ => MIT or GPLv2+ resources/jquery/ => MIT or GPLv2+ resources/jquery.tipsy => MIT resources/jquery.ui => MIT or GPLv2+ skins/vector/csshover.htc => LGPLv2+ skins/common/wikibits.js => says: " Written by Jonathan Snook, http://www.snook.ca/jonathan Add-ons by Robert Nyman, http://www.robertnyman.com Author says "The credit comment is all it takes, no license. Go crazy with it!:-)" From http://www.robertnyman.com/2005/11/07/the-ultimate-getelementsbyclassname/ " So, provided we can figure out if the wikibits.js is ok, I think it should be: GPLv2+ and MIT and public domain and CC-BY-SA and ASL2.0 2. rpmlint says: Might rm -f these: mediawiki119.noarch: W: hidden-file-or-dir /usr/share/mediawiki119/extensions/Gadgets/.gitreview mediawiki119.noarch: W: hidden-file-or-dir /usr/share/mediawiki119/extensions/ParserFunctions/.gitreview mediawiki119.noarch: W: hidden-file-or-dir /usr/share/mediawiki119/extensions/Vector/.gitreview mediawiki119.noarch: E: version-control-internal-file /usr/share/mediawiki119/extensions/.gitignore mediawiki119.noarch: W: hidden-file-or-dir /usr/share/mediawiki119/extensions/WikiEditor/.gitreview mediawiki119.noarch: W: hidden-file-or-dir /usr/share/mediawiki119/extensions/Renameuser/.gitreview mediawiki119.noarch: E: version-control-internal-file /usr/share/doc/mediawiki119-1.19.0/docs/html/.gitignore mediawiki119.noarch: W: hidden-file-or-dir /usr/share/mediawiki119/extensions/Nuke/.gitreview mediawiki119.noarch: W: hidden-file-or-dir /usr/share/mediawiki119/extensions/ConfirmEdit/.gitreview Might chmod 755 these: mediawiki119.noarch: E: non-executable-script /usr/share/mediawiki119/includes/normal/UtfNormalTest2.php 0644L /usr/bin/php mediawiki119.noarch: E: non-executable-script /usr/share/mediawiki119/extensions/ConfirmEdit/captcha.py 0644L /usr/bin/python can be ignored: mediawiki119.noarch: W: install-file-in-docs /usr/share/doc/mediawiki119-1.19.0/INSTALL I don't see any further blockers aside from the fixes for rpmlint and the legal question. I'll add legal here for comment. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review