[Bug 819480] Review Request: limesurvey - a web-based survey application

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=819480

--- Comment #11 from Kevin Fenzi <kevin@xxxxxxxxx> 2012-05-10 16:02:04 EDT ---
ok, some misc comments on the version in comment #9: 

1) You did increase the release to 0.3%{?dist}, but you don't have any
changelog entries. Please add changelog entries for each new release at the end
explaining what you changed. 

2) Your links for the upload and templates still don't match up. You have: 

...

cp -pr upload ${RPM_BUILD_ROOT}%{_var}/www/limesurvey/upload
cp -pr templates ${RPM_BUILD_ROOT}%{_var}/www/limesurvey/templates
...

/bin/ln -sf ../../../var/limesurvey/upload
${RPM_BUILD_ROOT}%{_datadir}/limesurvey/upload
/bin/ln -sf ../../../var/limesurvey/templates
${RPM_BUILD_ROOT}%{_datadir}/limesurvey/templates
...

%attr(0775,apache,apache) %{_var}/www/limesurvey/templates
%attr(0775,apache,apache) %{_var}/www/limesurvey/upload

two of those use /var/www/ and one uses /var/limesurvery.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]