Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=820642 --- Comment #2 from Jason Tibbitts <tibbs@xxxxxxxxxxx> 2012-05-10 14:39:43 EDT --- I guess the licensing issue which caused so much problems has been fixed. You should not use macro forms of simple executables, like %{__rm}. See http://fedoraproject.org/wiki/Packaging:Guidelines#Macros: Macro forms of system executables SHOULD NOT be used except when there is a need to allow the location of those executables to be configurable. For example, rm should be used in preference to %{__rm}, but %{__python} is acceptable. %defattr(-, root, root, 0755) is unnecessary. BuildRoot: %clean and the first line of %install are unnecessary unless you intend to build this for EPEL5. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review