Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: hdparm https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225882 andy.grimm@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andy.grimm@xxxxxxxxxx ------- Additional Comments From andy.grimm@xxxxxxxxxx 2007-02-03 17:34 EST ------- This one has several rpmlint errors: rpmlint on ./hdparm-6.9-1.src.rpm W: hdparm summary-ended-with-dot A utility for displaying and/or setting hard disk parameters. - Remove the dot E: hdparm tag-not-utf8 %changelog E: hdparm non-utf8-spec-file hdparm.spec - make sure that umlauted characters and such are utf8-encoded, not latin-1 E: hdparm no-cleaning-of-buildroot %install - clean $RPM_BUILD_ROOT at the beginning of %install. W: hdparm mixed-use-of-spaces-and-tabs (spaces: line 7, tab: line 9) W: hdparm patch-not-applied Patch2: hdparm-6.3-idestruct.patch - Remove the patch if it's no longer needed Also: * LICENSE.TXT must be included as a %doc Other things look fine. Checked: * md5sum matches upstream * specfile is clean * license is acceptable * buildrequires is fine * no locales, no shlibs, no relocations, etc. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review