Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: logrotate https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226104 ruben@xxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|ruben@xxxxxxxxxxxxxxxx |pvrabec@xxxxxxxxxx CC| |ruben@xxxxxxxxxxxxxxxx Flag|fedora-review? |fedora-review- ------- Additional Comments From ruben@xxxxxxxxxxxxxxxx 2007-02-03 17:28 EST ------- * RPM name is OK * Builds fine in mock * File list looks OK Needs work: * BuildRoot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) (wiki: PackagingGuidelines#BuildRoot) * Missing SMP flags. If it doesn't build with it, please add a comment (wiki: PackagingGuidelines#parallelmake) * Spec file: some paths are not replaced with RPM macros (wiki: QAChecklist item 7) * No downloadable source. Please give the full URL in the Source tag. * The package should contain the text of the license (wiki: Packaging/ReviewGuidelines) Notes: * There's no need to add -g to RPM_OPT_FLAGS, it's included by default * Use DESTDIR instead of PREFIX in %install * Preserve timestamps with install -p in %install * Is it necessary to create the empty logrotate.status? Rpmlint output: rpmlint of logrotate-3.7.4-11.fc6.i386.rpm:W: logrotate no-url-tag E: logrotate zero-length /var/lib/logrotate.status -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review