Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: glib2 https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225804 roozbeh@xxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED ------- Additional Comments From roozbeh@xxxxxxxxxxxxx 2007-02-03 17:26 EST ------- Another suggestion (over Pedro's) is to make the "1:0.14" requirement a macro, as it's used two times, the second time being in the middle of the spec file where one may forget to update: %define pkgconfig_version 1:0.14 [...] pkgconfig >= %{pkgconfig_version} I skimmed the Packaging Guidelines also. All looks either good or don't-know-what-to-do now. As for setup requirement, since there is a requires chain of "setup -> basesystem -> glibc -> glib2", it's fine. For the executable files in /etc/profile.d, I will ping the authorities! -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review