Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=820361 jiri vanek <jvanek@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED --- Comment #8 from jiri vanek <jvanek@xxxxxxxxxx> 2012-05-10 08:16:01 EDT --- ===summary=== ==must be fixed:== =MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. [7] *fail* there is missing BUildRequires =MUST: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. Apply common sense. *fail* as already mentioned, one is missing ( I have done this review with BuildRequires: xorg-x11-utils included in spec) ==should be fixed if there is will and reason to do so:== =rpmlint technic warning =MUST: Permissions on files must be set properly. Executables should be set with executable permissions, for example. [15] *fail* It looks like shared library have 775, I suggest to exactly specify permissions in specfile (however, default 775 are usable), so this can be considered as ok =SHOULD: your package should contain man pages for binaries/scripts. If it doesn't, work with upstream to add them where they make sense.[32] No manual pages. In this case I miss some more info how to enable this (for ANY jvm) =SHOULD: The reviewer should test that the package functions as described. A package should not segfault instead of running, for example. I have tried, and I was unable to verified. I have included ptisnovs a openjdk QA to test this. But we have faield to verify even old java-access-bridge If you have any more ideas how to enable it and verify it I will be very glad Especially the "function test" is important for me, unless ptisnovs will find the way:) ==todo when the package is out:== =test on arm =include and verify with openjdk7 I know I'm not master-reviewer so feel free to correct me and Ihope I have not overlook something. Thanx for your work, and looking forward for fixed version -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review