Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: screen https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226400 ed@xxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |mmaslano@xxxxxxxxxx Flag|fedora-review? |fedora-review+ ------- Additional Comments From ed@xxxxxxx 2007-02-03 17:18 EST ------- Hi folks, here's a quick review: good: + source matches upstream (where "upstream" apparently == Juergen, not savannah.gnu.org) + license is GPL v2 -- OK + BuildRoot OK + scriptlets OK + dir ownership looks OK needswork: - since upstream includes a copy of the license, please include it in %doc - please list the license as "GPL", not "GPL2" rpmlint: - rpmlint whines about a few things (the permissions appear to be OK to ignore since screen needs them): http://linux.dell.com/files/fedora/FixBuildRequires/mock-results-core/i386/screen-4.0.3-2.fc7.src.rpm/result/rpmlint.log Please make the two tiny changes above and this package is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review