Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: expect https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225743 ruben@xxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|ruben@xxxxxxxxxxxxxxxx |mitr@xxxxxxxxxx CC| |ruben@xxxxxxxxxxxxxxxx Flag|fedora-review? |fedora-review- ------- Additional Comments From ruben@xxxxxxxxxxxxxxxx 2007-02-03 17:13 EST ------- * RPM name is OK * Source expect-5.43.0.tar.gz is the same as upstream * This is the latest version * Builds fine in mock * rpmlint of expectk looks OK * rpmlint of expect-devel looks OK * File list of expectk looks OK * File list of expect-devel looks OK * File list of expect looks OK Needs work: * Use of buildroot is not consistant (wiki: PackagingGuidelines#UsingBuildRootOptFlags) * BuildRoot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) (wiki: PackagingGuidelines#BuildRoot) * Spec file: some paths are not replaced with RPM macros (wiki: QAChecklist item 7) * The package should contain the text of the license (wiki: Packaging/ReviewGuidelines) Minor: * Duplicate BuildRequires: tcl-devel (by tk-devel), libX11-devel (by tk-devel), autoconf (by automake) Notes: * Please use {?dist} in the Release tag * Can you use make DESTDIR instead of make INSTALLROOT? * Replace /usr/share/man with %{_docdir} everywhere * Are you willing to consider building with --disable-static. You're not packaging static libraries, and this saves some build time. * If one of the packages is a gui application, a .desktop file should be installed (wiki: PackagingGuidelines#desktop) rpmlint of expect-5.43.0-6.i386.rpm:E: expect invalid-soname /usr/lib/libexpect5.43.so libexpect5.43.so E: expect script-without-shebang /usr/lib/expect5.43/pkgIndex.tcl E: expect wrong-script-interpreter /usr/lib/expect5.43/cat-buffers "expect" E: expect non-executable-script /usr/lib/expect5.43/cat-buffers 0644 -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review