Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=533558 Jason Tibbitts <tibbs@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|fedora-package-review@redha |package-review@lists.fedora |t.com |project.org Flag|fedora-review? |fedora-review+ --- Comment #14 from Jason Tibbitts <tibbs@xxxxxxxxxxx> 2012-05-09 15:19:07 EDT --- Somehow I never noticed that the legal blocker had been lifted. I sure wish you had pinged me. Since I already did the review, everything still builds fine and there's been no new release upstream which would render any of the earlier work invalid, I'm just going to go ahead and approve this. If you're still interested, feel free to move forward if the process. If you're not, please just go ahead and close this out and accept my apologies. APPROVED One note, though, since the packaging guidelines have evolved since I first looked at this. You can remove the %defattr bit from %files since it is unneeded on everything Fedora and EPEL supports. If you do not intend to build for EPEL5, you can remove the BuildRoot: line, the entire %clean section and the first line of %install. You should also be able to remove the %build section since it's empty. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review