Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=819480 --- Comment #5 from Kevin Fenzi <kevin@xxxxxxxxx> 2012-05-09 10:05:33 EDT --- ok, a few general comments here. ;) First, now that we are in review, please remember to increase the release and add a changelog entry everytime you fix issues. This helps make sure that I am looking at the same version you are and avoids confusion. Attaching spec and srpms to the bug can be anoying for folks who wish to just look at the spec easily. See me about getting some space on fedorapeople.org to place your spec and src.rpm files on. Some misc small things we should fix: 1) Please fix the Summary. "The limesurvey RPM" doesn't tell people what this is. Think of it as if you were someone who had never heard of limesurvey. Describe it in a short sentence. 2) You will need to work on the files section some more: In %files, when you specify a directory, it takes that and everything under it. When you specify %dir it only includes that specific directory. You shouldn't include files/directories twice. This results in a bunch of: warning: File listed twice errors from rpmbuild. So, you are going to have to drop the: %{_datadir}/limesurvey/* and list in turn _every_ directory in there, and also "%dir %{_datadir}/limesurvey/" to get the top directory. 3) Once files is fixed up, we need to finish an install and see if it completes. I've not looked in detail at the install, but if it simply makes a config.php file or the like, we might consider shipping a placeholder one of those to make it easy for fedora users to simply edit the config file without needing to run the installer. 4) Once thats determined, we need to make sure the application actually works. ;) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review