Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=812586 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #3 from Petr Pisar <ppisar@xxxxxxxxxx> 2012-05-09 08:46:40 EDT --- Changes in spec file: --- perl-POE-Component-Client-Ping.spec.old 2012-05-07 13:07:34.018006702 +0200 +++ perl-POE-Component-Client-Ping.spec 2012-05-09 14:33:07.019017873 +0200 @@ -1,6 +1,6 @@ Name: perl-POE-Component-Client-Ping Version: 1.171 -Release: 1%{?dist} +Release: 2%{?dist} Summary: Non-blocking ICMP ping client License: GPL+ or Artistic Group: Development/Libraries @@ -11,6 +11,11 @@ BuildArch: noarch BuildRequires: perl(ExtUtils::MakeMaker) BuildRequires: perl(POE) >= 1.007 +BuildRequires: perl(Time::HiRes) >= 1.2 +BuildRequires: perl(Exporter) +BuildRequires: perl(Carp) +BuildRequires: perl(Socket) +BuildRequires: perl(POE::Session) BuildRequires: perl(Test::More) Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) @@ -60,5 +65,8 @@ %changelog +* Mon May 07 2012 Remi Collet <remi@xxxxxxxxxxxxxxxxx> - 1.171-2 +- comment from review (#812586) + * Sun Apr 15 2012 Remi Collet <remi@xxxxxxxxxxxxxxxxx> - 1.171-1 - Specfile autogenerated by cpanspec 1.78. > TODO: Remove already implicit %defattr form %files section. Not reflected. Ok. > TODO: Build-require `perl(Time::HiRes) >= 1.2' > (lib/POE/Component/Client/Ping.pm:33, META.yml). > TODO: Build-require `perl(Exporter)' (lib/POE/Component/Client/Ping.pm:9). > FIX: Build-require `perl(Carp)' (lib/POE/Component/Client/Ping.pm:30). > FIX: Build-require `perl(Socket)' (lib/POE/Component/Client/Ping.pm:32). > FIX: Build-require `perl(POE::Session)' (lib/POE/Component/Client/Ping.pm:35). +BuildRequires: perl(Time::HiRes) >= 1.2 +BuildRequires: perl(Exporter) +BuildRequires: perl(Carp) +BuildRequires: perl(Socket) +BuildRequires: perl(POE::Session) Ok. $ rpmlint perl-POE-Component-Client-Ping.spec ../SRPMS/perl-POE-Component-Client-Ping-1.171-2.fc18.src.rpm ../RPMS/noarch/perl-POE-Component-Client-Ping-1.171-2.fc18.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. Package builds in F18 (http://koji.fedoraproject.org/koji/taskinfo?taskID=4064805). Ok. > Haven't really understood difference between FIX and TODO in your comment, > but all are fixed. The FIX things must be fixed to pass review. In context of Perl modules, the difference is whether the module is part of binary `perl' package, or not. TODO modules dual-lives on CPAN now and they can emerge in Fedora in the future. Then such module becomes sub-packaged from main perl package to dual-live with newer CPAN version and other packages will have to require it once that will happens. So it's sort of future-compatibility issue. Resolution: Package APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review