Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=767985 --- Comment #7 from T.C. Hollingsworth <tchollingsworth@xxxxxxxxx> 2012-05-09 06:00:10 EDT --- Thanks for taking this! I've updated it to address all the above concerns and fix a bug: Spec: http://tchol.org/fedora/man2html.spec SRPM: http://tchol.org/fedora/man2html-1.6-2.g.fc17.src.rpm Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4064432 % rpmlint SPECS/man2html.spec # these two addressed in our conversation above SPECS/man2html.spec:118: W: configure-without-libdir-spec SPECS/man2html.spec:148: E: hardcoded-library-path in %{_prefix}/lib/man2html/ # rpmlint doesn't understand %patches SPECS/man2html.spec: W: patch-not-applied Patch3: man2html-cgi.patch <snip list of every patch> 0 packages and 1 specfiles checked; 1 errors, 21 warnings. % rpmlint RPMS/x86_64/man2html-1.6-2.g.fc17.x86_64.rpm RPMS/x86_64/man2html-core-1.6-2.g.fc17.x86_64.rpm # this is documented as a groff macro, not sure why rpmlint doesn't lik it man2html.x86_64: W: manual-page-warning /usr/share/man/man1/hman.1.gz 7: warning: macro `LO' not defined # cache directory for cgi scripts man2html.x86_64: E: non-standard-dir-perm /var/cache/man2html 0775L # unlikely to be fixed, upstream is dead man2html-core.x86_64: E: incorrect-fsf-address /usr/share/doc/man2html-core-1.6/COPYING # see above man2html-core.x86_64: W: manual-page-warning /usr/share/man/man1/man2html.1.gz 6: warning: macro `LO' not defined 2 packages and 0 specfiles checked; 2 errors, 2 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review