[Bug 787193] Review Request: compat-vala - compatibility version of the Vala compiler

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=787193

--- Comment #5 from Ralph Bean <rbean@xxxxxxxxxx> 2012-05-08 16:43:48 EDT ---
#1) Can you change the ticket name to vala-compat so it's consistent with the
package?

#2) I noticed that the "find -L /etc/alternatives/...." lines in %posttrans are
noisy when they are run in the absence of other installations of vala; if
/etc/alternatives/vala does not exist, it prints out noisily to stderr when you
install vala-compat.  You should replace those find -L lines with "if [ -L
/etc/alternatives/some_file ]; then" or another solution of your choice.

Barring those two items, I can complete the full review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]