Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=819678 --- Comment #4 from Jonathan Underwood <jonathan.underwood@xxxxxxxxx> 2012-05-08 13:40:29 EDT --- (In reply to comment #3) > Quick spec review: > > 1. I see some things that are no longer needed like BuildRoot:, rm -rf > $RPM_BUILD_ROOT in %install, %clean, and %defattr in %files but I'm assuming > that these are in the Fedora cmake package so I guess it's not worth deviating > from their package. > Yes, I took the approach of deviating as little as possible. These things are harmless, but enable build on older rhel, if you were masochistic enough to try. > 2. Should the Require for the -gui package be arch dependent? i.e.: > Requires: %{name} = %{version}-%{release} > to > Requires: %{name}${?_isa} = %{version}-%{release} > Probably so - have changed this. > > There's a lot of rpmlint output but I'm assuming it's largely the same as the > regular cmake package in Fedora. Yes - I'm loathed to deviate too much from the original package. > The only two things I think should be fixed > are: > cmake28.src:24: W: mixed-use-of-spaces-and-tabs (spaces: line 9, tab: line 24) Fixed. > cmake28.x86_64: E: non-executable-script > /usr/share/cmake28/Modules/SquishRunTestCase.sh 0644L /bin/sh This is intentional, the header of that file says: # # This script launches a GUI test using Squish. You should not call # the script directly; instead, you should acces it via the # SQUISH_ADD_TEST macro that is defined in FindSquish.cmake. Spec URL: http://jgu.fedorapeople.org/cmake28.spec SRPM URL: http://jgu.fedorapeople.org/cmake28-2.8.8-2.el6.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review