Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: xchat https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226551 bdpepple@xxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|bdpepple@xxxxxxxxxxxxx |caillon@xxxxxxxxxx CC| |bdpepple@xxxxxxxxxxxxx Flag|fedora-review? |fedora-review- ------- Additional Comments From bdpepple@xxxxxxxxxxxxx 2007-02-03 16:20 EST ------- Good: * Source URL is canonical * Group Tag is from the official list * All paths begin with macros * All directories are owned by this or other packages * Make succeeds even when %{_smp_mflags} is defined Must Fix: * Package should have ownership of %{_libdir}/xchat Minor: * Not preferred buildroot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) * Duplicate BuildRequires: perl (by perl), glib2-devel (by GConf2-devel), pkgconfig (by GConf2-devel), gtk2-devel (by gtkspell-devel) * some rpmlint errors that aren't blockers: W: xchat incoherent-version-in-changelog 1.2.6.6-8 1:2.6.6-8.fc7 E: xchat tag-not-utf8 %changelog W: xchat non-conffile-in-etc /etc/gconf/schemas/apps_xchat_url_handler.schemas -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review