Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=819237 --- Comment #3 from Ville Skyttä <ville.skytta@xxxxxx> 2012-05-07 16:52:55 EDT --- Martin, do you need a sponsor? If yes, be sure to mention it and set the FE-NEEDSPONSOR blocker, see docs at https://fedoraproject.org/wiki/PackageMaintainers/Join#Create_Your_Review_Request https://fedoraproject.org/wiki/Package_Review_Process Be also sure to run rpmlint on source rpm too and fix applicable issues, it reveals e.g.: vdr-screenshot.src:6: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 6) The unstripped-binary-or-object warning needs to be fixed. Haven't looked into it yet, but an usual reason is missing executable permissions on the *.so. Unless someone beats me to it, I'll look into reviewing this later (no sooner than next weekend, though). In the meantime, I also suggest looking into other vdr-* plugin packages in Fedora 17+ and "modernizing" your package like they're done - e.g. no need for so many %globals because that stuff is already defined in vdr-devel's macros (%vdr_*) etc. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review