[Bug 767985] Review Request: man2html - Convert man pages to HTML

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=767985

Michael Schwendt <mschwendt@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mschwendt@xxxxxxxxx

--- Comment #3 from Michael Schwendt <mschwendt@xxxxxxxxx> 2012-05-07 16:20:45 EDT ---
> %setup -q -n man-%{version}%{posttag}
> tar -zxf %SOURCE1

Hint: %setup can extract multiple tarballs, too:

%setup -q -n man-%{version}%{posttag} -a1


> %files
> %{_libdir}/../lib/man2html

Really unusual. Nothing forces you to use %_libdir, especially not if the value
of this variable is not passed into the source code's build framework as an
option. So, let's see:

> %build
> # not autoconf
> ./configure -d +fhs

$ grep libdir configure
$

That custom configure script understands several options, however, and defaults
to -prefix=/usr and then derives other paths from that prefix. It hardcodes a
confdir="${confprefix}/lib" path, for example, and the Debian sources hardcode
/usr/lib, too.  => Using %_libdir makes no sense.

  /usr/lib/man2html

The spec file would also be more readable when making explicit that a directory
is to be included and not a single file. A trailing slash does the trick:

  /usr/lib/man2html/


* https://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags

At least the CGI executables are not built with %optflags yet.


*
https://fedoraproject.org/wiki/Packaging:Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment

What's the status with regard to that?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]