Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=818454 --- Comment #6 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxx> 2012-05-07 10:16:16 EDT --- (In reply to comment #5) > (In reply to comment #3) > > Thank you for comments! > > > > (In reply to comment #2) > > > - License is GPLv2+, not just GPLv2 (try running licensecheck on COPYING or > > > linecache19.rb). > > So please check the above comment on License: line > > > > Yep, I saw that. The license in the mentioned files is however clearly GPLv2+. > So I would suggest querying the upstream what's actually right. Stricter license tag is no problem here. > > > - In %check section, the pushd should be associated with popd. > > Well, not necessary... > > > > No, but cleaner :) (why not use "cd" in that case?) Will fix when importing to Fedora git, or next update if any blocker remains. > > > - As for the docs, I would leave COPYING and possibly README in the main > > > package and move the rest into the doc subpackage. > > Well, this is already done... > > > > Nope, VERSION, NEWS, ChangeLog and AUTHORS files are in the main package - > these are the files I am talking about. Ah, now I can see what you see. Then IMO at least AUTHORS MUST be in main (copyright holder or so is the important imformation as well as COPYING file). IMO NEWS should also be in main package (well, it is "news"). ChangeLog can be in -doc subpackage, well, however I think either will do. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review