Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=812586 --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> 2012-05-07 07:39:25 EDT --- Source file is original. Ok. Source0 and URL are usable Ok. Summary verified from lib/POE/Component/Client/Ping.pm. Ok. License verified from lib/POE/Component/Client/Ping.pm. Ok. BuildRoot definition and cleaning present due to EPEL-5 compatibility. Ok. Description verified from lib/POE/Component/Client/Ping.pm. Ok. No XS code used, noarch BuildArch is Ok. TODO: Remove already implicit %defattr form %files section. TODO: Build-require `perl(Time::HiRes) >= 1.2' (lib/POE/Component/Client/Ping.pm:33, META.yml). TODO: Build-require `perl(Exporter)' (lib/POE/Component/Client/Ping.pm:9). FIX: Build-require `perl(Carp)' (lib/POE/Component/Client/Ping.pm:30). FIX: Build-require `perl(Socket)' (lib/POE/Component/Client/Ping.pm:32). FIX: Build-require `perl(POE::Session)' (lib/POE/Component/Client/Ping.pm:35). All tests pass. Ok. $ rpmlint perl-POE-Component-Client-Ping.spec ../SRPMS/perl-POE-Component-Client-Ping-1.171-1.fc18.src.rpm ../RPMS/noarch/perl-POE-Component-Client-Ping-1.171-1.fc18.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-POE-Component-Client-Ping-1.171-1.fc18.noarch.rpm drwxr-xr-x 2 root root 0 May 7 13:30 /usr/share/doc/perl-POE-Component-Client-Ping-1.171 -rw-r--r-- 1 root root 1759 Mar 7 04:43 /usr/share/doc/perl-POE-Component-Client-Ping-1.171/CHANGES -rw-r--r-- 1 root root 1902 Sep 13 2009 /usr/share/doc/perl-POE-Component-Client-Ping-1.171/README -rw-r--r-- 1 root root 6645 May 7 13:30 /usr/share/man/man3/POE::Component::Client::Ping.3pm.gz drwxr-xr-x 2 root root 0 May 7 13:30 /usr/share/perl5/vendor_perl/POE drwxr-xr-x 2 root root 0 May 7 13:30 /usr/share/perl5/vendor_perl/POE/Component drwxr-xr-x 2 root root 0 May 7 13:30 /usr/share/perl5/vendor_perl/POE/Component/Client -rw-r--r-- 1 root root 31341 Mar 7 04:41 /usr/share/perl5/vendor_perl/POE/Component/Client/Ping.pm File permissions and layout are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-POE-Component-Client-Ping-1.171-1.fc18.noarch.rpm |sort |uniq -c 1 perl(Carp) 1 perl(Exporter) 1 perl(:MODULE_COMPAT_5.14.2) 1 perl(POE) >= 1.007 1 perl(POE::Session) 1 perl(Socket) 1 perl(strict) 1 perl(Symbol) 1 perl(Time::HiRes) 1 perl(vars) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-POE-Component-Client-Ping-1.171-1.fc18.noarch.rpm |sort |uniq -c 1 perl(POE::Component::Client::Ping) = 1.171 1 perl-POE-Component-Client-Ping = 1.171-1.fc18 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-POE-Component-Client-Ping-1.171-1.fc18.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F18 (http://koji.fedoraproject.org/koji/taskinfo?taskID=4059704). Ok. Otherwise package is in line with Fedora and Perl packaging guidelines. Please correct all `FIX' prefixed issues, correct `TODO' items, and provide new spec file. Resolution: Package NOT approved. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review