Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=812583 --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> 2012-05-07 06:58:04 EDT --- Source file is original. Ok. URL and Source0 are usable. Ok TODO: Upstream links source tarballs to different place (http://forge.fusioninventory.org/projects/fusioninventory-agent-task-snmpquery/files). Please align Source0. This package is a rename and it obsoletes-provides old package properly. Ok. Summary verified from lib/FusionInventory/Agent/Task/NetInventory.pm. Ok. License verified from README and LICENSE. Ok. Description verified from README. Ok. This package does not use any XS code. noarch BuildArch is Ok. BuildRoot defined and cleaned because of EPEL-5 compatibility. Ok. ??? Missing run-time requires for tests FIX: Build-require `perl(inc::Module::Install)' instead of `perl(ExtUtils::MakeMaker) (Makefile.PL:1). FIX: Build-require `perl(File::Which)' (Makefile.PL:13). TODO: Consider removing bundled inc/* files to use the ones provided by distribution. Otherwise you will need to build-require all modules used by by the inc/* code (like YAML::Tiny, File::Temp, etc.) FIX: Build-require all inc/* code dependencies. FIX: Build-require `perl(threads)' for running tests (lib/FusionInventory/Agent/Task/NetInventory.pm:5). FIX: Build-require `perl(threads::shared)' for running tests (lib/FusionInventory/Agent/Task/NetInventory.pm:6). TODO: Build-require `perl(base)' for running tests (lib/FusionInventory/Agent/Task/NetInventory.pm:7). FIX: Build-require `perl(FusionInventory::Agent::Task)' for runnig tests (lib/FusionInventory/Agent/Task/NetInventory.pm:7). TODO: Build-require `perl(constant)' for running tests (lib/FusionInventory/Agent/Task/NetInventory.pm:9). TODO: Build-require `perl(Encode)' for running tests (lib/FusionInventory/Agent/Task/NetInventory.pm:14). FIX: Build-require `perl(FusionInventory::Agent::SNMP)' for running tests (lib/FusionInventory/Agent/Task/NetInventory.pm:17). FIX: Build-require `perl(FusionInventory::Agent::XML::Query)' for running tests (lib/FusionInventory/Agent/Task/NetInventory.pm:18). FIX: Build-require `perl(FusionInventory::Agent::Tools)' for running tests (lib/FusionInventory/Agent/Task/NetInventory.pm:19). FIX: Build-require `perl(FusionInventory::Agent::Tools::Network)' for running tests (lib/FusionInventory/Agent/Task/NetInventory.pm:20). FIX: Build-require `perl(FusionInventory::Agent::XML::Response)' for running tests (t/message.t:9). FIX: Package does not build because of missing `perl(FusionInventory::Agent::Task::NetDiscovery) >= 2.1' build-requirement. This is fatal. Please correct the `FIX' issues and provide new spec file. Resolution: Package NOT approved. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review