Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=819180 --- Comment #2 from Jaroslav Reznik <jreznik@xxxxxxxxxx> 2012-05-07 04:33:15 EDT --- Name: ok Version: ok Release: ok Summary: ok (could be a little bit shorter with brief description but) License: ok (as found in LICENSE file) URL: ok Source: BuildRequires: ok BuildArch: ok, noarch Description: ok Macros uses consistently: ok Documentation: COPYING.LIB is missing For tests you should use the %check section [1]. I'd let the desktop-file-install for desktop file even it's hidden. I don't see any icon installed so the %post, %postun and %posttrans scriptlets are useless here (to recreate icon cache). [1] http://fedoraproject.org/wiki/How_to_create_an_RPM_package#.25check_section -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review