Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: mtools https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226162 ed@xxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ed@xxxxxxx Flag| |fedora-review- ------- Additional Comments From ed@xxxxxxx 2007-02-03 15:22 EST ------- Hi there, here's a quick review: good: + source matches upstream + license is OK and correctly included (GPL) + specfile is legible and looks good + dir ownership and permissions look good + has %clean and "rm -rf $RPM_BUILD_ROOT" + pot/preun scriptlets look good + dir ownership and perms OK needswork: - please see the rpmlint output at: http://linux.dell.com/files/fedora/FixBuildRequires/mock-results-core/i386/mtools-3.9.10-3.fc7.src.rpm/result/rpmlint.log which lists a few items that need attention - please use the preferred BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review