Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=819184 --- Comment #1 from Volker Fröhlich <volker27@xxxxxx> 2012-05-06 11:47:02 EDT --- The development symlink should not be there, as there are no headers. I suggest to just delete it. Since one of the seemingly private libraries is installed in libdir, rpmlint complains about not running ldconfig. If this library really is private, it should ideally not be in libdir, but in the subdirectory along with the others. The provides of the final package also contain all those private libraries; that should be filtered. %dir %{_libdir}/qupzilla and %{_libdir}/qupzilla/*.so could be simplified to %{_libdir}/qupzilla. Probably use the name macro here. There are a couple of warnings for the desktop file. You should also run a scriplet for the icons installed in datadir/icons: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache Consider to include README.md, as it contains some useful information. I suggest to add a -f where you're deleting the "useless plugin", just in case it disappears in a future release. Buildroot rm in the install section, clean section and buildroot definition are definitely not necessary, as you BR qt >= 4.7, which is only in Fedora. I think the package could have a better Summary, but it's not a must. I noticed, there are a couple of plug-ins and private libraries with BSD licenses. As far as I understand http://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Multiple_Licensing_Scenarios, this should be mentioned or the files should even be put to sub-packages. Somebody once suggested on one of my reviews, to remove the trailing slash after the domain name on the URL. I don't mind it, but I'd like to mention it. Are USE_WEBGL and USE_QTWEBKIT_2_2 options of interest? Both should work, I think. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review