Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=811750 Michel Alexandre Salim <michel+fdr@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |michel+fdr@xxxxxxxxxxxx --- Comment #5 from Michel Alexandre Salim <michel+fdr@xxxxxxxxxxxx> 2012-05-05 01:58:08 EDT --- Thanks! Starting the review by installing the required tw2 packages by hand into my local mock. rpmlint output: python-tw2-jqplugins-gritter-2.0.1-1.fc17.src.rpm: python-tw2-jqplugins-gritter.src: W: spelling-error Summary(en_US) jQuery -> j Query, query, equerry python-tw2-jqplugins-gritter.src: W: summary-not-capitalized C jQuery gritter (growl-like pop-ups) for ToscaWidgets2 python-tw2-jqplugins-gritter.src: W: spelling-error %description -l en_US ui -> ii, u, i 1 packages and 0 specfiles checked; 0 errors, 3 warnings. python-tw2-jqplugins-gritter-2.0.1-1.fc17.noarch.rpm: python-tw2-jqplugins-gritter.noarch: W: spelling-error Summary(en_US) jQuery -> j Query, query, equerry python-tw2-jqplugins-gritter.noarch: W: summary-not-capitalized C jQuery gritter (growl-like pop-ups) for ToscaWidgets2 python-tw2-jqplugins-gritter.noarch: W: spelling-error %description -l en_US ui -> ii, u, i 1 packages and 0 specfiles checked; 0 errors, 3 warnings. All are harmless spelling false-positives. Regarding the bundled javascript -- is that in the main tw2-jquery package? I don't see any file in -gritter that seems to belong to another already-shipped package. Review checklist below. Note the comment on macro (though that's not important), but more importantly, directory ownership * TODO Review [90%] - [X] Names [2/2] - [X] Package name - [X] Spec name - [X] Package version [2/2] http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Package_Versioning - [X] Version number http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Version_Tag - [X] Release tag http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Release_Tag http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Pre-Release_packages - [X] Meets [[http://fedoraproject.org/wiki/Packaging/Guidelines][guidelines]] - [X] Source files match upstream sha256sum ./tw2.jqplugins.gritter-2.0.1.tar.gz ~/rpmbuild/SOURCES/tw2.jqplugins.gritter-2.0.1.tar.gz 7491cf18380010c1cbc6008769a07897f0f301b3135050172aabdfb37dad4adf ./tw2.jqplugins.gritter-2.0.1.tar.gz 7491cf18380010c1cbc6008769a07897f0f301b3135050172aabdfb37dad4adf /home/michel/rpmbuild/SOURCES/tw2.jqplugins.gritter-2.0.1.tar.gz - [X] [[http://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries][No bundled libraries]] - [X] License [4/4] - [X] License is Fedora-approved - [X] No licensing conflict - [X] License field accurate - [X] License included iff packaged by upstream - [X] rpmlint [2/2] - [X] on src.rpm - [X] on x86_64.rpm - [X] Language & locale [2/2] - [X] Spec in US English - [X] Spec legible - [-] Build [2/3] - [X] Koji results local mock in lieue of Koji - [X] BRs complete - [ ] Directory ownership The wildcard makes this package also owns the following, which should be owned by packages it depend on: %{python_sitelib}/tw2 %{python_sitelib}/tw2/jqplugins Perhaps change this to: %{python_sitelib}/tw2.jqplugins.gritter* %{python_sitelib}/tw2/jqplugins/gritter - [X] Spec inspection [5/5] - [X] No duplicate files - [X] File permissions - [X] Filenames must be UTF-8 - [X] no BuildRoot ([[https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag][except if targeting RHEL5]]) - [X] Macro usage consistent note that you can just use 0%{?rhel} rather than %{?rhel}%{!?rhel:0} -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review