Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=818730 Chris Tyler <chris@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@xxxxxxxxxxx --- Comment #1 from Chris Tyler <chris@xxxxxxxxxxx> 2012-05-04 16:31:06 EDT --- Informal review while we await a sponsor... N MUST: rpmlint must be run on the source rpm and all binary rpms the build produces. The output should be posted in the review.[1] *** Please post rpmlint output. Y MUST: The package must be named according to the Package Naming Guidelines . Y MUST: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. [2] . Y MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. N MUST: The License field in the package spec file must match the actual license. [3] *** The license on github is MIT, the spec file says GPLv3 Y MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc.[4] Y MUST: The spec file must be written in American English. [5] Y MUST: The spec file for the package MUST be legible. [6] N MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use md5sum for this task. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this. *** The Source0: field should point to a reliable upstream URL - the one in the spec file cannot be retrieved. To get a specific commit, use something like https://github.com/ryanb/ruby-warrior/tarball/94dc735 (for commit 94dc735) *** Additions to the source should be in other files, e.g., Source1: waterbear.desktop ...stop. Fix these up and I'll restart the review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review