Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: finger https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225754 ruben@xxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|ruben@xxxxxxxxxxxxxxxx |rvokal@xxxxxxxxxx CC| |ruben@xxxxxxxxxxxxxxxx Flag|fedora-review? |fedora-review- ------- Additional Comments From ruben@xxxxxxxxxxxxxxxx 2007-02-03 14:46 EST ------- * RPM name is OK * Source bsd-finger-0.17.tar.gz is the same as upstream * Builds fine in mock * File list of finger-server looks OK * File list of finger looks OK * Config files of finger-server looks OK * BuildRoot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) (wiki: PackagingGuidelines#BuildRoot) * BuildRequires: gcc should not be included (wiki: PackagingGuidelines#Exceptions) * BuildRequires: perl should not be included (wiki: PackagingGuidelines#Exceptions) * Encoding should be UTF-8 * Missing SMP flags. If it doesn't build with it, please add a comment (wiki: PackagingGuidelines#parallelmake) * The package should contain the text of the license (wiki: Packaging/ReviewGuidelines) Rpmlint is not silent: Source RPM: W: finger summary-ended-with-dot The finger client. E: finger tag-not-utf8 %changelog W: finger no-url-tag E: finger non-utf8-spec-file finger.spec W: finger mixed-use-of-spaces-and-tabs (spaces: line 62, tab: line 88) rpmlint of finger-server: W: finger-server summary-ended-with-dot The finger daemon. E: finger-server tag-not-utf8 %changelog W: finger-server no-url-tag E: finger-server non-readable /usr/sbin/in.fingerd 0711 E: finger-server non-standard-executable-perm /usr/sbin/in.fingerd 0711 rpmlint of finger-server: is it OK ? (press Enter if yes, or else type your comment below) rpmlint of finger: W: finger summary-ended-with-dot The finger client. E: finger tag-not-utf8 %changelog W: finger no-url-tag -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review