Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810939 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> 2012-05-04 09:32:07 EDT --- Source file is original. Ok. URL and Source0 are usable Ok. Summary verified from lib/bareword/filehandles.pm. Ok. License verified from lib/bareword/filehandles.pm and LICENSE. Ok. Description verified from lib/bareword/filehandles.pm. Ok. Package uses XS code, architecture specific BuilArch is Ok. All releases provide perl(Test::Pod::Coverage) >= 1.08, nonqualified dependency is Ok. All releases provide perl(Test::Pod) >= 1.41, nonqualified dependency is Ok. TODO: If you have patched Lexical::SealRequireHints dependency out, then you could remove `perl >= 0:5.008001' build-require. All tests pass. Ok. $ rpmlint perl-bareword-filehandles.spec ../SRPMS/perl-bareword-filehandles-0.003-1.fc18.src.rpm ../RPMS/x86_64/perl-bareword-filehandles-* perl-bareword-filehandles.src: W: spelling-error %description -l en_US lexically -> lexical, exotically, allergically perl-bareword-filehandles.src: W: spelling-error %description -l en_US builtin -> built in, built-in, built perl-bareword-filehandles.x86_64: W: spelling-error %description -l en_US lexically -> lexical, exotically, allergically perl-bareword-filehandles.x86_64: W: spelling-error %description -l en_US builtin -> built in, built-in, built perl-bareword-filehandles.x86_64: E: incorrect-fsf-address /usr/share/doc/perl-bareword-filehandles-0.003/LICENSE 3 packages and 1 specfiles checked; 1 errors, 4 warnings. TODO: Correct `builtin' spelling. TODO: Report to upstream out-dated FSF address $ rpm -q -lv -p ../RPMS/x86_64/perl-bareword-filehandles-0.003-1.fc18.x86_64.rpm drwxr-xr-x 2 root root 0 May 4 15:22 /usr/lib64/perl5/vendor_perl/auto/bareword drwxr-xr-x 2 root root 0 May 4 15:22 /usr/lib64/perl5/vendor_perl/auto/bareword/filehandles -rwxr-xr-x 1 root root 10216 May 4 15:22 /usr/lib64/perl5/vendor_perl/auto/bareword/filehandles/filehandles.so drwxr-xr-x 2 root root 0 May 4 15:22 /usr/lib64/perl5/vendor_perl/bareword -rw-r--r-- 1 root root 1815 May 4 15:22 /usr/lib64/perl5/vendor_perl/bareword/filehandles.pm drwxr-xr-x 2 root root 0 May 4 15:22 /usr/share/doc/perl-bareword-filehandles-0.003 -rw-r--r-- 1 root root 356 Mar 15 2011 /usr/share/doc/perl-bareword-filehandles-0.003/Changes -rw-r--r-- 1 root root 18291 Mar 15 2011 /usr/share/doc/perl-bareword-filehandles-0.003/LICENSE -rw-r--r-- 1 root root 316 Mar 15 2011 /usr/share/doc/perl-bareword-filehandles-0.003/README -rw-r--r-- 1 root root 2245 May 4 15:22 /usr/share/man/man3/bareword::filehandles.3pm.gz File layout is Ok. $ rpm -q --requires -p ../RPMS/x86_64/perl-bareword-filehandles-0.003-1.fc18.x86_64.rpm |sort |uniq -c 1 libc.so.6()(64bit) 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 perl(B::Hooks::OP::Check) 1 perl(:MODULE_COMPAT_5.14.2) 1 perl(strict) 1 perl(warnings) 1 perl(XSLoader) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 1 rtld(GNU_HASH) Binary requires are Ok. $ rpm -q --provides -p ../RPMS/x86_64/perl-bareword-filehandles-0.003-1.fc18.x86_64.rpm |sort |uniq -c 1 perl(bareword::filehandles) = 0.003 1 perl-bareword-filehandles = 0.003-1.fc18 1 perl-bareword-filehandles(x86-64) = 0.003-1.fc18 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/x86_64/perl-bareword-filehandles-0.003-1.fc18.x86_64.rpm Binary dependencies resolvable. Ok. Package builds in F18 (http://koji.fedoraproject.org/koji/taskinfo?taskID=4052725). Ok. Package is in line with Fedora and Perl packaging guidelines. Please consider fixing all `TODO' items before building this package. Resolution: Package APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review