Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810937 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> 2012-05-04 08:35:34 EDT --- Source file is original. Ok. URL and Source0 are usable. Ok. Summary verified from lib/multidimensional.pm. Ok. License verified from lib/multidimensional.pm and LICENSE. Ok. Description verified from lib/multidimensional.pm. Ok. Package use XS code, architecture specific BuildArch is Ok. TODO: If you patched out Lexical::SealRequireHints because of new enough perl, you could remove `perl >= 0:5.008' build-require. All releases provides perl(Test::More) >= 0.88, nonqualified dependency is Ok. All releases provides perl(Test::Pod::Coverage) >= 1.08, nonqualified dependency is Ok. All releases provides perl(Test::Pod) >= 1.41, nonqualified dependency is Ok. All tests pass. Ok. $ rpmlint perl-multidimensional.spec ../SRPMS/perl-multidimensional-0.010-1.fc18.src.rpm ../RPMS/x86_64/perl-multidimensional-* perl-multidimensional.src: W: spelling-error %description -l en_US sigil -> vigil perl-multidimensional.src: W: spelling-error %description -l en_US lexically -> lexical, exotically, allergically perl-multidimensional.x86_64: W: spelling-error %description -l en_US sigil -> vigil perl-multidimensional.x86_64: W: spelling-error %description -l en_US lexically -> lexical, exotically, allergically 3 packages and 1 specfiles checked; 0 errors, 4 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/x86_64/perl-multidimensional-0.010-1.fc18.x86_64.rpm drwxr-xr-x 2 root root 0 May 4 14:27 /usr/lib64/perl5/vendor_perl/auto/multidimensional -rwxr-xr-x 1 root root 6104 May 4 14:27 /usr/lib64/perl5/vendor_perl/auto/multidimensional/multidimensional.so -rw-r--r-- 1 root root 1861 May 4 14:27 /usr/lib64/perl5/vendor_perl/multidimensional.pm drwxr-xr-x 2 root root 0 May 4 14:27 /usr/share/doc/perl-multidimensional-0.010 -rw-r--r-- 1 root root 1243 Jan 27 13:34 /usr/share/doc/perl-multidimensional-0.010/Changes -rw-r--r-- 1 root root 18407 Jan 27 13:34 /usr/share/doc/perl-multidimensional-0.010/LICENSE -rw-r--r-- 1 root root 323 Jan 27 13:34 /usr/share/doc/perl-multidimensional-0.010/README -rw-r--r-- 1 root root 2296 May 4 14:27 /usr/share/man/man3/multidimensional.3pm.gz File permissions and layout are Ok. $ rpm -q --requires -p ../RPMS/x86_64/perl-multidimensional-0.010-1.fc18.x86_64.rpm |sort |uniq -c 1 libc.so.6()(64bit) 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 perl(B::Hooks::OP::Check) >= 0.19 1 perl(:MODULE_COMPAT_5.14.2) 1 perl(strict) 1 perl(warnings) 1 perl(XSLoader) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 1 rtld(GNU_HASH) Binary requires are Ok. $ rpm -q --provides -p ../RPMS/x86_64/perl-multidimensional-0.010-1.fc18.x86_64.rpm |sort |uniq -c 1 perl(multidimensional) = 0.010 1 perl-multidimensional = 0.010-1.fc18 1 perl-multidimensional(x86-64) = 0.010-1.fc18 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/x86_64/perl-multidimensional-0.010-1.fc18.x86_64.rpm Binary dependencies resolvable. Ok. Package builds in F18 (http://koji.fedoraproject.org/koji/taskinfo?taskID=4052566). Ok. Package is in line with Fedora and Perl packaging guidelines. Please consider fixing all `TODO' items before building this package. Resolution: Package APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review