Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=817436 --- Comment #3 from Mathieu Bridon <bochecha@xxxxxxxxxxxxxxxxx> 2012-05-04 05:06:58 EDT --- (In reply to comment #2) > - Using macros in the URL is not very handy for copy-and-paste. I don't want to change the Source0 URL $ spectool -S bonesi.spec Source0: https://bonesi.googlecode.com/files/bonesi-0.2.0.tar.gz > - As far as I know is it not needed to mark man pages as %doc. Right, I keep forgetting about this, thanks. > - Include README and License in %doc Oops, no idea how I missed that, good catch! > - Consider to add the example file 50k-bots, browserlist.txt, and urllist.txt Good idea. Spec URL: http://bochecha.fedorapeople.org/packages/bonesi.spec SRPM URL: http://bochecha.fedorapeople.org/packages/bonesi-0.2.0-2.fc17.src.rpm $ rpmlint bonesi*.{spec,rpm} 3 packages and 1 specfiles checked; 0 errors, 0 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review