[Bug 771137] Review Request: decibel-audio-player - straightforward music player

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=771137

--- Comment #9 from Volker Fröhlich <volker27@xxxxxx> 2012-05-03 18:11:13 EDT ---
I think I can speak for Christoph here, that he was referring to:

sed 'bla' %{_bindir}/blah

instead of

sed 'bla' /usr/bin/blah


Please write a meaningful changelog and bump your release when you change
something. This makes work a lot easier for reviewers.

Don't BR sed, see
http://fedoraproject.org/wiki/Packaging:Guidelines#Exceptions_2

Forget my comment about the scripts, it is all fine.

I must have been very tired when I wrote about the harmonization, so you can
basically forget about that too. One thing though: I suggest to use "sed
'expression' filename" instead of cating into sed. 

Don't use the install macro %{__install}. Just make it "install".

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]