Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=816124 --- Comment #12 from Michael Schwendt <mschwendt@xxxxxxxxx> 2012-05-03 16:59:34 EDT --- Has a test-build in koji been done yet? And rpmlint output for it? Now that the shared libs have been moved to their correct subpkgs, a closer look at the result of lines such as the following would be needed: > # XXX Nuke non-versioned archives and symlinks > rm -f ${RPM_BUILD_ROOT}%{_libdir}/{libdb.a,libdb_cxx.a} > rm -f ${RPM_BUILD_ROOT}%{_libdir}/libdb-%{__soversion_major}.so > rm -f ${RPM_BUILD_ROOT}%{_libdir}/libdb_cxx-%{__soversion_major}.so > rm -f ${RPM_BUILD_ROOT}%{_libdir}/libdb_tcl-%{__soversion_major}.so Just based on the spec file, one cannot guess what SONAMEs are involved and what ldconfig will do to these installed files. The comment behind the 'XXX' is far from clear. It's a basic programmer's mistake to not answer the "Why?" but only repeat the "What?" in a comment. The spec file would be more comprehensible, if it explained _why_ these installed files are deleted. Further, > rm -f ${RPM_BUILD_ROOT}%{_libdir}/libdb_tcl.so With this, no -ldb_tcl is possible anymore. Contrary to > %{_libdir}/libdb-%{__soversion}.so > %{_libdir}/libdb.so > %{_libdir}/libdb_cxx-%{__soversion}.so > %{_libdir}/libdb_cxx.so in the other packages. * There is no libdb4-tcl-devel package? The subpackages do > Requires: %{name} = %{version}-%{release} which is not arch-specific: https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package > %files cxx-devel > %defattr(-,root,root,-) > %{_libdir}/libdb_cxx.so > %{_includedir}/%{name}/db_cxx.h The includedir is unowned. > This package is used as replacement for comap-db and db4. And no Obsoletes/Provides as would be normal for a replacement package? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review