Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: adjtimex https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225239 kevin@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|kevin@xxxxxxxxx |mlichvar@xxxxxxxxxx Flag|fedora-review? |fedora-review+ ------- Additional Comments From kevin@xxxxxxxxx 2007-02-03 13:37 EST ------- OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 9888b54f418d7cc120fd3a4222f01c9c adjtimex-1.21.tar.gz 9888b54f418d7cc120fd3a4222f01c9c adjtimex-1.21.tar.gz.1 OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. See below - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. See below - No rpmlint output. OK - final provides and requires are sane: SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have dist tag OK - Should package latest version 0 bugs - check for outstanding bugs on package. Issues: 1. The License tag is wrong. It should be "GPL", not "distributable" 2. Buildroot is not correct. Use the suggested buildroot. 3. rpmlint says: rpmlint on ./adjtimex-debuginfo-1.21-1.fc7.i386.rpm W: adjtimex-debuginfo invalid-license distributable Fix license tag W: adjtimex-debuginfo no-url-tag Should add perhaps: URL: http://ibiblio.org/pub/Linux/system/admin/time/adjtimex.lsm rpmlint on ./adjtimex-1.21-1.fc7.i386.rpm W: adjtimex summary-ended-with-dot A utility for adjusting kernel time variables. Summary shouldn't end in . All these are pretty minor. Provided you make the above changes, I will be happy to APPROVE this. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review