Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=803057 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> 2012-05-03 09:17:32 EDT --- Source file is original. Ok. URL and Source0 are usable. Ok. Summary verified from lib/Test/Valgrind.pm. Ok. License verified from lib/Test/Valgrind.pm. Ok. Description verified from lib/Test/Valgrind.pm. Ok. BuildRoot tag is needed for EPEL5. Ok. %clean section is needed for EPEL5. Ok. Resulting package does not contain binary dependent code. noarch BuildArch is Ok. I'm not sure removing the XS code is wise. I think it's used by Test::Valgrind::Command::Perl to gather suppression data. Also then XSLoader should be needed at run-time. BuildRequire perl(Test::Pod::Coverage) is not qualified because 1.08 version is provided by all releases. Ok. TODO: Build-require `perl(Test::Pod) >= 0.18' as you requires optional Test::Pod::Coverage. TODO: Build-require `perl(XSLoader)' because of optional test (t/20-bad.t:16). BuildRequire perl(Test::Pod) is not qualified because 1.22 version is provided by all releases. Ok. All tests pass. Ok. $ rpmlint perl-Test-Valgrind.spec ../SRPMS/perl-Test-Valgrind-1.13-2.fc18.src.rpm ../RPMS/noarch/perl-Test-Valgrind-1.13-2.fc18.noarch.rpm perl-Test-Valgrind.src: W: spelling-error Summary(en_US) suppressions -> suppression, suppression's, suppress ions perl-Test-Valgrind.src: W: spelling-error %description -l en_US memcheck -> checkmate perl-Test-Valgrind.src: W: spelling-error %description -l en_US suppressions -> suppression, suppression's, suppress ions perl-Test-Valgrind.noarch: W: spelling-error Summary(en_US) suppressions -> suppression, suppression's, suppress ions perl-Test-Valgrind.noarch: W: spelling-error %description -l en_US memcheck -> checkmate perl-Test-Valgrind.noarch: W: spelling-error %description -l en_US suppressions -> suppression, suppression's, suppress ions 2 packages and 1 specfiles checked; 0 errors, 6 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Test-Valgrind-1.13-2.fc18.noarch.rpm drwxr-xr-x 2 root root 0 May 3 14:53 /usr/share/doc/perl-Test-Valgrind-1.13 -rw-r--r-- 1 root root 5040 Aug 25 2011 /usr/share/doc/perl-Test-Valgrind-1.13/Changes -rw-r--r-- 1 root root 6648 Aug 25 2011 /usr/share/doc/perl-Test-Valgrind-1.13/README drwxr-xr-x 2 root root 0 Aug 25 2011 /usr/share/doc/perl-Test-Valgrind-1.13/samples -rwxr-xr-x 1 root root 172 Nov 29 2009 /usr/share/doc/perl-Test-Valgrind-1.13/samples/map.pl -rw-r--r-- 1 root root 22202 Nov 29 2009 /usr/share/doc/perl-Test-Valgrind-1.13/samples/xml-output-protocol4.txt -rw-r--r-- 1 root root 12146 Nov 29 2009 /usr/share/doc/perl-Test-Valgrind-1.13/samples/xml-output.txt -rw-r--r-- 1 root root 4716 May 3 14:53 /usr/share/man/man3/Test::Valgrind.3pm.gz -rw-r--r-- 1 root root 2846 May 3 14:53 /usr/share/man/man3/Test::Valgrind::Action.3pm.gz -rw-r--r-- 1 root root 2590 May 3 14:53 /usr/share/man/man3/Test::Valgrind::Action::Captor.3pm.gz -rw-r--r-- 1 root root 2517 May 3 14:53 /usr/share/man/man3/Test::Valgrind::Action::Suppressions.3pm.gz -rw-r--r-- 1 root root 2630 May 3 14:53 /usr/share/man/man3/Test::Valgrind::Action::Test.3pm.gz -rw-r--r-- 1 root root 2352 May 3 14:53 /usr/share/man/man3/Test::Valgrind::Carp.3pm.gz -rw-r--r-- 1 root root 3103 May 3 14:53 /usr/share/man/man3/Test::Valgrind::Command.3pm.gz -rw-r--r-- 1 root root 2401 May 3 14:53 /usr/share/man/man3/Test::Valgrind::Command::Aggregate.3pm.gz -rw-r--r-- 1 root root 2837 May 3 14:53 /usr/share/man/man3/Test::Valgrind::Command::Perl.3pm.gz -rw-r--r-- 1 root root 2648 May 3 14:53 /usr/share/man/man3/Test::Valgrind::Command::PerlScript.3pm.gz -rw-r--r-- 1 root root 2495 May 3 14:53 /usr/share/man/man3/Test::Valgrind::Component.3pm.gz -rw-r--r-- 1 root root 2607 May 3 14:53 /usr/share/man/man3/Test::Valgrind::Parser.3pm.gz -rw-r--r-- 1 root root 2404 May 3 14:53 /usr/share/man/man3/Test::Valgrind::Parser::Suppressions::Text.3pm.gz -rw-r--r-- 1 root root 2390 May 3 14:53 /usr/share/man/man3/Test::Valgrind::Parser::Text.3pm.gz -rw-r--r-- 1 root root 2393 May 3 14:53 /usr/share/man/man3/Test::Valgrind::Parser::XML.3pm.gz -rw-r--r-- 1 root root 2509 May 3 14:53 /usr/share/man/man3/Test::Valgrind::Parser::XML::Twig.3pm.gz -rw-r--r-- 1 root root 2819 May 3 14:53 /usr/share/man/man3/Test::Valgrind::Report.3pm.gz -rw-r--r-- 1 root root 3772 May 3 14:53 /usr/share/man/man3/Test::Valgrind::Session.3pm.gz -rw-r--r-- 1 root root 2734 May 3 14:53 /usr/share/man/man3/Test::Valgrind::Suppressions.3pm.gz -rw-r--r-- 1 root root 3195 May 3 14:53 /usr/share/man/man3/Test::Valgrind::Tool.3pm.gz -rw-r--r-- 1 root root 2692 May 3 14:53 /usr/share/man/man3/Test::Valgrind::Tool::memcheck.3pm.gz drwxr-xr-x 2 root root 0 May 3 14:53 /usr/share/perl5/vendor_perl/Test drwxr-xr-x 2 root root 0 May 3 14:53 /usr/share/perl5/vendor_perl/Test/Valgrind -rw-r--r-- 1 root root 9939 Aug 25 2011 /usr/share/perl5/vendor_perl/Test/Valgrind.pm drwxr-xr-x 2 root root 0 May 3 14:53 /usr/share/perl5/vendor_perl/Test/Valgrind/Action -rw-r--r-- 1 root root 3366 Aug 25 2011 /usr/share/perl5/vendor_perl/Test/Valgrind/Action.pm -rw-r--r-- 1 root root 3029 Aug 25 2011 /usr/share/perl5/vendor_perl/Test/Valgrind/Action/Captor.pm -rw-r--r-- 1 root root 3933 Aug 25 2011 /usr/share/perl5/vendor_perl/Test/Valgrind/Action/Suppressions.pm -rw-r--r-- 1 root root 4432 Aug 25 2011 /usr/share/perl5/vendor_perl/Test/Valgrind/Action/Test.pm -rw-r--r-- 1 root root 1404 Aug 25 2011 /usr/share/perl5/vendor_perl/Test/Valgrind/Carp.pm drwxr-xr-x 2 root root 0 May 3 14:53 /usr/share/perl5/vendor_perl/Test/Valgrind/Command -rw-r--r-- 1 root root 3568 Aug 25 2011 /usr/share/perl5/vendor_perl/Test/Valgrind/Command.pm -rw-r--r-- 1 root root 2107 Aug 25 2011 /usr/share/perl5/vendor_perl/Test/Valgrind/Command/Aggregate.pm -rw-r--r-- 1 root root 5537 Aug 25 2011 /usr/share/perl5/vendor_perl/Test/Valgrind/Command/Perl.pm -rw-r--r-- 1 root root 2869 Aug 25 2011 /usr/share/perl5/vendor_perl/Test/Valgrind/Command/PerlScript.pm -rw-r--r-- 1 root root 2289 Aug 25 2011 /usr/share/perl5/vendor_perl/Test/Valgrind/Component.pm drwxr-xr-x 2 root root 0 May 3 14:53 /usr/share/perl5/vendor_perl/Test/Valgrind/Parser -rw-r--r-- 1 root root 2108 Aug 25 2011 /usr/share/perl5/vendor_perl/Test/Valgrind/Parser.pm drwxr-xr-x 2 root root 0 May 3 14:53 /usr/share/perl5/vendor_perl/Test/Valgrind/Parser/Suppressions -rw-r--r-- 1 root root 3828 Aug 25 2011 /usr/share/perl5/vendor_perl/Test/Valgrind/Parser/Suppressions/Text.pm -rw-r--r-- 1 root root 1542 Aug 25 2011 /usr/share/perl5/vendor_perl/Test/Valgrind/Parser/Text.pm drwxr-xr-x 2 root root 0 May 3 14:53 /usr/share/perl5/vendor_perl/Test/Valgrind/Parser/XML -rw-r--r-- 1 root root 1616 Aug 25 2011 /usr/share/perl5/vendor_perl/Test/Valgrind/Parser/XML.pm -rw-r--r-- 1 root root 4958 Aug 25 2011 /usr/share/perl5/vendor_perl/Test/Valgrind/Parser/XML/Twig.pm -rw-r--r-- 1 root root 3118 Aug 25 2011 /usr/share/perl5/vendor_perl/Test/Valgrind/Report.pm -rw-r--r-- 1 root root 11692 Aug 25 2011 /usr/share/perl5/vendor_perl/Test/Valgrind/Session.pm -rw-r--r-- 1 root root 4246 Aug 25 2011 /usr/share/perl5/vendor_perl/Test/Valgrind/Suppressions.pm drwxr-xr-x 2 root root 0 May 3 14:53 /usr/share/perl5/vendor_perl/Test/Valgrind/Tool -rw-r--r-- 1 root root 3959 Aug 25 2011 /usr/share/perl5/vendor_perl/Test/Valgrind/Tool.pm -rw-r--r-- 1 root root 4905 Aug 25 2011 /usr/share/perl5/vendor_perl/Test/Valgrind/Tool/memcheck.pm File permissions and layout are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Test-Valgrind-1.13-2.fc18.noarch.rpm |sort |uniq -c 1 perl(base) 1 perl(Carp) 1 perl(Digest::MD5) 1 perl(Env::Sanctify) 1 perl(Fcntl) 1 perl(File::HomeDir) >= 0.86 1 perl(File::Path) 1 perl(File::Spec) 1 perl(File::Temp) >= 0.14 1 perl(Filter::Util::Call) 1 perl(List::Util) 1 perl(:MODULE_COMPAT_5.14.2) 1 perl(Perl::Destruct::Level) 1 perl(POSIX) 1 perl(Scalar::Util) 1 perl(strict) 1 perl(Test::Builder) 1 perl(Test::Valgrind::Suppressions) 1 perl(version) 1 perl(warnings) 1 perl(XML::Twig) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 1 valgrind >= 3.1.0 Binary requires are Ok if the XS code is not distributed. $ rpm -q --provides -p ../RPMS/noarch/perl-Test-Valgrind-1.13-2.fc18.noarch.rpm |sort |uniq -c 1 perl(Test::Valgrind) = 1.13 1 perl-Test-Valgrind = 1.13-2.fc18 1 perl(Test::Valgrind::Action) = 1.13 1 perl(Test::Valgrind::Action::Captor) = 1.13 1 perl(Test::Valgrind::Action::Suppressions) = 1.13 1 perl(Test::Valgrind::Action::Test) = 1.13 1 perl(Test::Valgrind::Carp) = 1.13 1 perl(Test::Valgrind::Command) = 1.13 1 perl(Test::Valgrind::Command::Aggregate) = 1.13 1 perl(Test::Valgrind::Command::Perl) = 1.13 1 perl(Test::Valgrind::Command::PerlScript) = 1.13 1 perl(Test::Valgrind::Component) = 1.13 1 perl(Test::Valgrind::Parser) = 1.13 1 perl(Test::Valgrind::Parser::Suppressions::Text) = 1.13 1 perl(Test::Valgrind::Parser::Text) = 1.13 1 perl(Test::Valgrind::Parser::XML) = 1.13 1 perl(Test::Valgrind::Parser::XML::Twig) = 1.13 1 perl(Test::Valgrind::Parser::XML::Twig::Elt) = 1.13 1 perl(Test::Valgrind::Report) = 1.13 1 perl(Test::Valgrind::Report::Suppressions) 1 perl(Test::Valgrind::Session) = 1.13 1 perl(Test::Valgrind::Suppressions) = 1.13 1 perl(Test::Valgrind::Tool) = 1.13 1 perl(Test::Valgrind::Tool::memcheck) = 1.13 1 perl(Test::Valgrind::Tool::memcheck::Report) = 1.13 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Test-Valgrind-1.13-2.fc18.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F18 (http://koji.fedoraproject.org/koji/taskinfo?taskID=4049263). Ok. Package is in line with Fedora and Perl packaging guidelines. Please consider fixing `TODO' items before building this package. Resolution: Package APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review