Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=817391 Matthias Runge <mrunge@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mrunge@xxxxxxxxxxxxxxxxx --- Comment #3 from Matthias Runge <mrunge@xxxxxxxxxxxxxxxxx> 2012-05-03 03:11:51 EDT --- Hmm, it looks like you simply took the spec from here http://jupiter.svn.sourceforge.net/viewvc/jupiter/packages/fuduntu/jupiter.spec?revision=225 and substituted any reference to original author to you. Ah, no, you also dropped the BuildRoot-definition and the empty preun: section. - your install-section is some verbose. It may be nice in fuduntu, RPM installs in fedora shall be silent. - You're changing sudoers file. If you're using that, you need to require it. - I guess, there's a more elegant way to get users added to sudoers. Esp. you're hard coding user ids (everything above 500) - you're simply adding a user and a group. please consult https://fedoraproject.org/wiki/Packaging:UsersAndGroups - There's no need to require coreutils, see https://fedoraproject.org/wiki/Packaging:Guidelines#Requires - you are the submitter. You can not review your own package. (you shouldn't set the fedora-review-flag) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review