Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=817311 pcpa <paulo.cesar.pereira.de.andrade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: |Review Request: miniupnpc - |libminiupnpc - Library and |Library and tool to control |tool to control NAT in |NAT in UPnP-enabled routers |UPnP-enabled routers | --- Comment #5 from pcpa <paulo.cesar.pereira.de.andrade@xxxxxxxxx> 2012-05-02 20:27:55 EDT --- Thanks for the review. I also reviewed my work again and besides renaming the package I also did: o check that the license; I originally copied this package from Mageia to Mandriva, (acknowledging that), and the license actually was incorrect as the LICENSE file is a no extra clauses BSD license. o enable build of tests, what required a patch to link the tests, but there is no make target to run the tests, so, no %check added. o install a preformatted manual page. Update for spec and srpm locations: Spec URL: http://kenobi.mandriva.com/~pcpa/miniupnpc.spec SRPM URL: http://kenobi.mandriva.com/~pcpa/miniupnpc-1.6-2.fc16.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review