Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=800930 Tom "spot" Callaway <tcallawa@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flag| |fedora-review? --- Comment #41 from Tom "spot" Callaway <tcallawa@xxxxxxxxxx> 2012-05-02 15:47:26 EDT --- === REVIEW === Needs Fixes: * You should run desktop-file-verify over the .desktop file. See: https://fedoraproject.org/wiki/Packaging/Guidelines#desktop-file-install_usage and be sure to add BuildRequires: desktop-file-utils * You have an explicit Requires: redeclipse-data, should that be a versioned requires to ensure clean upgrades? I think Requires: redeclipse-data = %{version}-%{release} even makes sense here. * rpmlint: cube2font.x86_64: W: spelling-error %description -l en_US utiliy -> utility, utilize This one is a legitimate typo. Please fix. Good: - rpmlint checks return: redeclipse.src: W: spelling-error Summary(en_US) Multiplayer -> Multiplier, Multiplexer redeclipse.src: W: spelling-error %description -l en_US multi -> mulch, mufti redeclipse.src: W: spelling-error %description -l en_US gameplay -> game play, game-play, nameplate redeclipse.src: W: spelling-error %description -l en_US gamemodes -> game modes, game-modes, gametes redeclipse.src: W: spelling-error %description -l en_US mutators -> commutators, mutilators, commutator redeclipse.src: W: invalid-url Source0: redeclipse-1.2-fs.tar.xz redeclipse.x86_64: W: spelling-error Summary(en_US) Multiplayer -> Multiplier, Multiplexer redeclipse.x86_64: W: spelling-error %description -l en_US multi -> mulch, mufti redeclipse.x86_64: W: spelling-error %description -l en_US gameplay -> game play, game-play, nameplate redeclipse.x86_64: W: spelling-error %description -l en_US gamemodes -> game modes, game-modes, gametes redeclipse.x86_64: W: spelling-error %description -l en_US mutators -> commutators, mutilators, commutator All of the above are safe to ignore. - package meets naming guidelines - package meets packaging guidelines - license (zlib and CC-BY-SA) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - macro use consistent - content is okay - no need for -docs - nothing in %doc affects runtime Fix those three items and I'll approve this. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review