Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=790560 --- Comment #4 from Jerry James <loganjerry@xxxxxxxxx> 2012-05-02 10:59:25 EDT --- (In reply to comment #3) > Permissions on /usr/bin/vinci are wrong: > -rwxrwxr-x 1 root root 59712 May 2 06:28 > /usr/bin/vinci > > To fix this, I'd recommend to use "install -m 755" instead of "cp -p" in > %install. Thanks for catching that. I've used your suggested fix. > Apart of this, to me, "Fixing the FSF address" is pretty pointless. I'd not do > this. I've had other reviewers demand that I do that for other packages. I guess we need a clear statement in the guidelines about such "fixing". In any case, I've removed it. New URLs: Spec URL: http://jjames.fedorapeople.org/vinci/vinci.spec SRPM URL: http://jjames.fedorapeople.org/vinci/vinci-1.0.5-2.fc18.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review