[Bug 816126] Review Request: python-django-dpaste - Dpaste is a code paste-bin application using Django

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=816126

--- Comment #5 from David Brown <david.brown@xxxxxxx> 2012-05-02 09:59:22 EDT ---
The lang files get included if you use both the line above and the -f argument
to files.

So the crux of the issue is that the directories de, en, de/LC_MESSAGES and
en/LC_MESSAGES aren't getting tracked by the rpm when you use the -f argument
to files. My recommendation would be to remove the -f argument to %files and
just use the line above in the files section.

To show how this can be an issue try installing your rpm then uninstalling it.
See if the directories mentioned above in the dpaste/locale directory get
removed. On my system they didn't get removed. This can cause issues later down
the road when the upstream maintainers choose to change how they are doing
things. Then during an upgrade from this version to the next version
directories are there that shouldn't be and could cause the upgrade to fail.

In my opinion its better to track everything in the rpm including all the
directories the package might touch. The only time its not okay if the
directory is owned by another package. So if the Requires for this package
track the locale directories already then this fix isn't needed.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]