[Bug 815814] Review Request: rubygem-paranoia - Cleaner re-implementation of acts_as_paranoid (ActiveRecord soft-delete plugin)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=815814

--- Comment #19 from Vít Ondruch <vondruch@xxxxxxxxxx> 2012-04-30 13:00:43 EDT ---
(In reply to comment #18)
> 2) I remove the test subdirectory (and a subdirectory, 'tmp', that is left
> after running tests) in the newly-added %check section. Please advise if there
> is a better place to do that.

Although that is correct, I suggest you to simplify the %check section a bit:

%check
pushd .%{gem_instdir}
RUBYOPT="-rfileutils" testrb test/*
popd

In this case, the test suite is executed in %{builddir} and you don't have to
take care about some leftovers.

Otherwise I am fine with the package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]