Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=800105 --- Comment #2 from Petr Pisar <ppisar@xxxxxxxxxx> 2012-04-30 11:53:53 EDT --- Source file is original. Ok. URL and Source0 are usable. Ok. Summary verified from lib/Net/Google/Calendar.pm. Ok. License verified from lib/Net/Google/Calendar.pm. Ok. Description verified from lib/Net/Google/Calendar.pm. Ok. No XS or C code found. noarch BuildArch is Ok. TODO: Remove the unneeded BuildRoot tag. FIX: Build-require `perl(XML::Atom::Link) for running tests (lib/Net/Google/Calendar/WebContent.pm:5) TODO: Build-require `perl(base) for running tests because this module can dual-live in the future (lib/Net/Google/Calendar/WebContent.pm:8) FIX: Build-require `perl(XML::Atom::Feed)' for running tests (lib/Net/Google/Calendar/FeedLink.pm:4) FIX: Build-require `perl(XML::Atom::Entry)' for running tests (lib/Net/Google/Calendar/FeedLink.pm:5) FIX: Build-require `perl(LWP::Simple)' for running tests (lib/Net/Google/Calendar/FeedLink.pm:7) FIX: Build-require `perl(XML::Atom::Thing)' for running tests (lib/Net/Google/Calendar/Base.pm:4) FIX: Build-require `perl(XML::Atom::Util)' for running tests (lib/Net/Google/Calendar/Base.pm:5) FIX: Build-require `perl(XML::Atom::Person)' for running tests (lib/Net/Google/Calendar/Person.pm:4) FIX: Build-require `perl(Data::Dumper)' for running tests (lib/Net/Google/Calendar/Entry.pm:4) Data::ICal and Data::ICal::Entry::Event not requires because they are optional. Ok. FIX: Build-require `perl(HTTP::Cookies)' for running tests (lib/Net/Google/Calendar.pm:5) FIX: Build-require `perl(HTTP::Request)' for running tests (lib/Net/Google/Calendar.pm:6) FIX: Build-require `perl(HTTP::Headers)' for running tests (lib/Net/Google/Calendar.pm:7) FIX: Build-require `perl(HTTP::Request::Common)' for running tests (lib/Net/Google/Calendar.pm:8) FIX: Build-require `perl(Carp)' for running tests (lib/Net/Google/Calendar.pm:18) TODO: Build-require `perl(Encode) for running tests because this module can dual-live in the future (lib/Net/Google/Calendar.pm:798) TODO: Build-require `perl(lib)' for running tests because this module can dual-live in the future (t/02events.t:6) TODO: Build-require `perl(Test::Pod) >= 1.14' for running optional tests (t/pod.t:7) TODO: Build-require `perl(Test::Pod::Coverage) >= 1.04' for running optional tests (t/pod-coverage.t:6) TODO: Remove unneeded `rm -rf $RPM_BUILD_ROOT' command from %install section TODO: Remove unneeded %clean section TODO: Remove unneeded %defattr macro from %files section TODO: Do not package `Readme' file as it deliver instruction for packager, not for the user or developer. All tests pass. Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Net-Google-Calendar-1.0-1.fc18.noarch.rpm drwxr-xr-x 2 root root 0 Apr 30 17:34 /usr/share/doc/perl-Net-Google-Calendar-1.0 -rw-r--r-- 1 root root 2896 Jul 20 2010 /usr/share/doc/perl-Net-Google-Calendar-1.0/Changes -rw-r--r-- 1 root root 88 Jul 20 2010 /usr/share/doc/perl-Net-Google-Calendar-1.0/Readme -rw-r--r-- 1 root root 197 Jul 20 2010 /usr/share/doc/perl-Net-Google-Calendar-1.0/TODO -rw-r--r-- 1 root root 291 Jul 20 2010 /usr/share/doc/perl-Net-Google-Calendar-1.0/USAGE -rw-r--r-- 1 root root 6319 Apr 30 17:34 /usr/share/man/man3/Net::Google::Calendar.3pm.gz -rw-r--r-- 1 root root 1739 Apr 30 17:34 /usr/share/man/man3/Net::Google::Calendar::Base.3pm.gz -rw-r--r-- 1 root root 2103 Apr 30 17:34 /usr/share/man/man3/Net::Google::Calendar::Calendar.3pm.gz -rw-r--r-- 1 root root 2207 Apr 30 17:34 /usr/share/man/man3/Net::Google::Calendar::Comments.3pm.gz -rw-r--r-- 1 root root 3585 Apr 30 17:34 /usr/share/man/man3/Net::Google::Calendar::Entry.3pm.gz -rw-r--r-- 1 root root 2379 Apr 30 17:34 /usr/share/man/man3/Net::Google::Calendar::FeedLink.3pm.gz -rw-r--r-- 1 root root 2064 Apr 30 17:34 /usr/share/man/man3/Net::Google::Calendar::Person.3pm.gz -rw-r--r-- 1 root root 2647 Apr 30 17:34 /usr/share/man/man3/Net::Google::Calendar::WebContent.3pm.gz drwxr-xr-x 2 root root 0 Apr 30 17:34 /usr/share/perl5/vendor_perl/Net drwxr-xr-x 2 root root 0 Apr 30 17:34 /usr/share/perl5/vendor_perl/Net/Google drwxr-xr-x 2 root root 0 Apr 30 17:34 /usr/share/perl5/vendor_perl/Net/Google/Calendar -rw-r--r-- 1 root root 20758 Apr 30 17:34 /usr/share/perl5/vendor_perl/Net/Google/Calendar.pm -rw-r--r-- 1 root root 1049 Apr 30 17:34 /usr/share/perl5/vendor_perl/Net/Google/Calendar/Base.pm -rw-r--r-- 1 root root 3209 Apr 30 17:34 /usr/share/perl5/vendor_perl/Net/Google/Calendar/Calendar.pm -rw-r--r-- 1 root root 2231 Apr 30 17:34 /usr/share/perl5/vendor_perl/Net/Google/Calendar/Comments.pm -rw-r--r-- 1 root root 16568 Apr 30 17:34 /usr/share/perl5/vendor_perl/Net/Google/Calendar/Entry.pm -rw-r--r-- 1 root root 3424 Apr 30 17:34 /usr/share/perl5/vendor_perl/Net/Google/Calendar/FeedLink.pm -rw-r--r-- 1 root root 2822 Apr 30 17:34 /usr/share/perl5/vendor_perl/Net/Google/Calendar/Person.pm -rw-r--r-- 1 root root 5565 Apr 30 17:34 /usr/share/perl5/vendor_perl/Net/Google/Calendar/WebContent.pm File permissions and layout are Ok. TODO: Package bin/google-calendar or remove the USAGE file. $ rpm -q --requires -p ../RPMS/noarch/perl-Net-Google-Calendar-1.0-1.fc18.noarch.rpm |sort | uniq -c 1 perl(base) 1 perl(Carp) 1 perl(Data::Dumper) 2 perl(DateTime) 1 perl(HTTP::Cookies) 1 perl(HTTP::Headers) 1 perl(HTTP::Request) 1 perl(HTTP::Request::Common) 1 perl(LWP::Simple) 2 perl(LWP::UserAgent) 1 perl(:MODULE_COMPAT_5.14.2) 2 perl(Net::Google::AuthSub) 1 perl(Net::Google::Calendar::Base) 1 perl(Net::Google::Calendar::Calendar) 1 perl(Net::Google::Calendar::Comments) 1 perl(Net::Google::Calendar::Entry) 1 perl(Net::Google::Calendar::FeedLink) 1 perl(Net::Google::Calendar::Person) 1 perl(strict) 1 perl(Test::More) 2 perl(URI) 2 perl(URI::Escape) 1 perl(vars) 1 perl(XML::Atom) 1 perl(XML::Atom) >= 0.37 1 perl(XML::Atom::Entry) 1 perl(XML::Atom::Feed) 1 perl(XML::Atom::Link) 1 perl(XML::Atom::Person) 1 perl(XML::Atom::Thing) 1 perl(XML::Atom::Util) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 TODO: Remove explicit Requires that are found automatically: perl(DateTime), perl(LWP::UserAgent), perl(Net::Google::AuthSub), perl(URI), perl(URI::Escape). TODO: Filter under-specified (unversioned) `perl(XML::Atom)' from run-time dependencies. FIX: Remove unneeded `perl(Test::More)' from run-time dependencies. FIX: Run-require `perl(Encode)' (lib/Net/Google/Calendar.pm:798). $ rpm -q --provides -p ../RPMS/noarch/perl-Net-Google-Calendar-1.0-1.fc18.noarch.rpm |sort | uniq -c 1 perl(Net::Google::Calendar) = 1.0 1 perl-Net-Google-Calendar = 1.0-1.fc18 1 perl(Net::Google::Calendar::Base) 1 perl(Net::Google::Calendar::Calendar) 1 perl(Net::Google::Calendar::Comments) 1 perl(Net::Google::Calendar::Entry) 1 perl(Net::Google::Calendar::FeedLink) 1 perl(Net::Google::Calendar::Person) 1 perl(Net::Google::Calendar::WebContent) Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Net-Google-Calendar-1.0-1.fc18.noarch.rpm Binary dependencies resolvable. Ok. $ rpmlint perl-Net-Google-Calendar.spec ../SRPMS/perl-Net-Google-Calendar-1.0-1.fc18.src.rpm ../RPMS/noarch/perl-Net-Google-Calendar-1.0-1.fc18.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. Package builds in F18 (http://koji.fedoraproject.org/koji/taskinfo?taskID=4035410). Ok. Otherwise package is in line with Fedora and Perl packaging guidelines. Please correct all `FIX' prefixed issues, consider fixing `TODO' items and provide new spec file. Resolution: Package NOT approved. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review