Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810926 --- Comment #16 from Vít Ondruch <vondruch@xxxxxxxxxx> 2012-04-30 11:36:53 EDT --- It gets lengthy, so I will start over. * Test suite - The current approach is OK and cannot be showstopper for a review. However, from my experience, if I may suggest, I would go following way: pushd .%{gem_instdir} %{rspec} popd - This is the easiest way IMO. I tried it, so you can just copy/paste. - The main difference is that the test suite is executed from %{builddir} instead of %{buildroot}. So the gem is still in its original state, including the binaries on the original places, so you don't have to fiddle too much with include paths (-I). Of course there are also disadvantages, but the advantages wins in this case IMO. - Hint: May be it would be worth of commenting the purpose of %{rspec} and %{rspec_format} macros. I was already confused by them, since I did not read carefully enough your previous comment :) * %{gem_libname} macro is not used anywhere. Overall, the package looks good in current state. I will approve it as soon as: 1) The gem will be available on rubygems.org 2) The LICENSE file will be fixed, or if there will be some note in the .spec file (you may have some ticket for that for example) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review