Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: k3b https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225957 ------- Additional Comments From ed@xxxxxxx 2007-02-03 12:01 EST ------- Hi there, The following are the review items that stand out. I realize that almost all of the includes are prefixed with "k3b" but nonetheless it would be nice to put all of them in a subdir such as: /usr/include/k3b/ Anyway, the list of items is: - please use the preferred BuildRoot - rpmlint complains about a number of things: - devel content in non-devel package (many files) - please consider creating a sub-dir such as /usr/include/k3b to contain all the k3b headers - dead patches are still being carried around and should probably be deleted: W: k3b patch-not-applied Patch1: k3b-0.11.3-kde32.patch W: k3b patch-not-applied Patch2: k3b-0.11.6-desktopfile.patch W: k3b patch-not-applied Patch5: k3b-0.11.14-version.patch W: k3b patch-not-applied Patch7: k3b-0.11.17-dao.patch W: k3b patch-not-applied Patch6: k3b-0.11.14-suid.patch W: k3b patch-not-applied Patch9: k3b-0.11.23-proxy.patch W: k3b patch-not-applied Patch8: k3b-0.12.2-statfs.patch - please remove prereq-use /sbin/ldconfig - I don't really understand this--can someone else please help explain it: /tmp/k3b-0.12.17-1.i386.rpm.30099/usr/share/applications/kde-k3b.desktop: warning: file contains key "DocPath", this key is currently reserved for use within KDE, and should in the future KDE releases be prefixed by "X-" - please consider adding %{?dist} to Release -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review